Skip to content

Save cache even when job failed #1168

Open
@morriq

Description

Description:
Currently, saving the cache is executed only when the job is successful:

setup-node/action.yml

Lines 38 to 39 in 39370e3

post: 'dist/cache-save/index.js'
post-if: success()

In my opinion, the job can fail for many reasons, and saving the package to the cache should be independent.

Justification:
Slowed-down job execution makes me prefer using a manual cache:

    - name: Always Save pnpm cache
      if: always() && steps.cache-pnpm.outputs.cache-hit != 'true'
      uses: actions/cache/save@v4
      with:
        path: |
          ${{ env.STORE_PATH }}
        key: ${{ steps.cache-pnpm.outputs.cache-primary-key }}

instead of cache input in action.

Are you willing to submit a PR?

Metadata

Assignees

No one assigned

    Labels

    feature requestNew feature or request to improve the current logic

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions