Merge pull request #2948 from actiontech/340

LordofAvernus · web-flow · commit bffc9317d38a · 2025-03-06T18:43:36.000+08:00
refactor: add TODO comments for HTTPS consideration
diff --git a/sqle/api/controller/v1/task.go b/sqle/api/controller/v1/task.go
@@ -1226,6 +1226,7 @@ func DownloadAuditFile(c echo.Context) error {
 
 }
 
+// TODO 这里没有考虑到sqled开启https的情况
 // TODO 和DMS一起抽离出一个工具函数
 func ReverseToSqle(c echo.Context, rewriteUrlPath, targetHost string) (err error) {
 	// c.Request().URL.Path = rewriteUrlPath
diff --git a/sqle/dms/common.go b/sqle/dms/common.go
@@ -201,6 +201,7 @@ func GetProjects() ([]string, error) {
 	return projectIds, nil
 }
 
+// TODO 这里没有考虑到sqled开启https的情况
 func RegisterAsDMSTarget(sqleConfig *config.SqleOptions) error {
 	controller.InitDMSServerAddress(sqleConfig.DMSServerAddress)
 	InitDMSServerAddress(sqleConfig.DMSServerAddress)

Original file line number	Diff line number	Diff line change
`@@ -1226,6 +1226,7 @@ func DownloadAuditFile(c echo.Context) error {`
`1226`	`1226`
`1227`	`1227`	`}`
`1228`	`1228`
	`1229`	`+// TODO 这里没有考虑到sqled开启https的情况`
`1229`	`1230`	`// TODO 和DMS一起抽离出一个工具函数`
`1230`	`1231`	`func ReverseToSqle(c echo.Context, rewriteUrlPath, targetHost string) (err error) {`
`1231`	`1232`	`// c.Request().URL.Path = rewriteUrlPath`
Original file line number	Diff line number	Diff line change
`@@ -201,6 +201,7 @@ func GetProjects() ([]string, error) {`
`201`	`201`	`return projectIds, nil`
`202`	`202`	`}`
`203`	`203`
	`204`	`+// TODO 这里没有考虑到sqled开启https的情况`
`204`	`205`	`func RegisterAsDMSTarget(sqleConfig *config.SqleOptions) error {`
`205`	`206`	`controller.InitDMSServerAddress(sqleConfig.DMSServerAddress)`
`206`	`207`	`InitDMSServerAddress(sqleConfig.DMSServerAddress)`