Improve test coverage

Author: ilijastuden

test/src/ApplyAuthenticationMiddlewareTest.php

@@ -0,0 +1,76 @@
+<?php
+
+/*
+ * This file is part of the Active Collab Authentication project.
+ *
+ * (c) A51 doo <[email protected]>. All rights reserved.
+ */
+
+namespace ActiveCollab\Authentication\Test;
+
+use ActiveCollab\Authentication\Adapter\BrowserSessionAdapter;
+use ActiveCollab\Authentication\AuthenticationResult\Transport\Authentication\AuthenticationTransport;
+use ActiveCollab\Authentication\AuthenticationResult\Transport\Authorization\AuthorizationTransport;
+use ActiveCollab\Authentication\Middleware\ApplyAuthenticationMiddleware;
+use ActiveCollab\Authentication\Test\AuthenticatedUser\AuthenticatedUser;
+use ActiveCollab\Authentication\Test\AuthenticatedUser\Repository as UserRepository;
+use ActiveCollab\Authentication\Test\Session\Repository as SessionRepository;
+use ActiveCollab\Authentication\Test\Session\Session;
+use ActiveCollab\Authentication\Test\TestCase\RequestResponseTestCase;
+use ActiveCollab\Cookies\Adapter\Adapter;
+use ActiveCollab\Cookies\Cookies;
+use ActiveCollab\Cookies\CookiesInterface;
+use Psr\Http\Message\ResponseInterface;
+use Psr\Http\Message\ServerRequestInterface;
+
+/**
+ * @package ActiveCollab\Authentication\Test
+ */
+class ApplyAuthenticationMiddlewareTest extends RequestResponseTestCase
+{
+    /**
+     * @var CookiesInterface
+     */
+    private $cookies;
+
+    /**
+     * {@inheritdoc}
+     */
+    public function setUp()
+    {
+        parent::setUp();
+
+        $this->cookies = new Cookies(new Adapter());
+    }
+
+    /**
+     * Test that user is authenticated.
+     */
+    public function testUserIsAuthenticated()
+    {
+        $user = new AuthenticatedUser(1, '[email protected]', 'Ilija Studen', '123');
+        $user_repository = new UserRepository([
+            '[email protected]' => new AuthenticatedUser(1, '[email protected]', 'Ilija Studen', '123'),
+        ]);
+        $session_repository = new SessionRepository([new Session('my-session-id', '[email protected]')]);
+
+        $session_cookie_name = 'test-session-cookie';
+
+        $session_adapter = new BrowserSessionAdapter($user_repository, $session_repository, $this->cookies, $session_cookie_name);
+        $session = $session_adapter->authenticate($user, []);
+
+        /** @var ServerRequestInterface $request */
+        $request = $this->request->withAttribute('test_transport', new AuthorizationTransport($session_adapter, $user, $session, [1, 2, 3]));
+
+        /** @var ResponseInterface $response */
+        $response = call_user_func(new ApplyAuthenticationMiddleware('test_transport'), $request, $this->response);
+
+        $this->assertInstanceOf(ResponseInterface::class, $response);
+
+        $set_cookie_header = $response->getHeaderLine('Set-Cookie');
+
+        $this->assertNotEmpty($set_cookie_header);
+        $this->assertContains($session_cookie_name, $set_cookie_header);
+        $this->assertContains('my-session-id', $set_cookie_header);
+    }
+}

test/src/GoogleAuthorizerTest.php

@@ -34,7 +34,7 @@ public function setUp()
 
     /**
      * @dataProvider providerInvalidCredentials
-     * @expectedException ActiveCollab\Authentication\Exception\InvalidAuthenticationRequestException
+     * @expectedException \ActiveCollab\Authentication\Exception\InvalidAuthenticationRequestException
      * @expectedExceptionMessage Authentication request data not valid
      */
     public function testInvalidCredentialsThrowsException($credentials)
@@ -55,7 +55,7 @@ public function providerInvalidCredentials()
     }
 
     /**
-     * @expectedException RuntimeException
+     * @expectedException \RuntimeException
      * @expectedExceptionMessage Unrecognized google_client
      */
     public function testExceptionIsThrownForInvalidAud()
@@ -68,7 +68,7 @@ public function testExceptionIsThrownForInvalidAud()
     }
 
     /**
-     * @expectedException RuntimeException
+     * @expectedException \RuntimeException
      * @expectedExceptionMessage Wrong issuer
      */
     public function testExceptionIsThrownForInvalidIss()
@@ -83,7 +83,7 @@ public function testExceptionIsThrownForInvalidIss()
     }
 
     /**
-     * @expectedException RuntimeException
+     * @expectedException \RuntimeException
      * @expectedExceptionMessage Email is not verified by Google
      */
     public function testExceptionIsThrownForInvalidUsername()
@@ -98,7 +98,7 @@ public function testExceptionIsThrownForInvalidUsername()
     }
 
     /**
-     * @expectedException ActiveCollab\Authentication\Exception\UserNotFoundException
+     * @expectedException \ActiveCollab\Authentication\Exception\UserNotFoundException
      * @expectedExceptionMessage User not found
      */
     public function testExceptionIsThrownForNotFoundUser()
@@ -116,7 +116,7 @@ public function testExceptionIsThrownForNotFoundUser()
     }
 
     /**
-     * @expectedException ActiveCollab\Authentication\Exception\UserNotFoundException
+     * @expectedException \ActiveCollab\Authentication\Exception\UserNotFoundException
      * @expectedExceptionMessage User not found
      */
     public function testExceptionIsThrownForNotAuthenticatedUser()
@@ -157,6 +157,7 @@ public function testUserIsFoundAndVerified()
         $user = $google_authorizer->verifyCredentials(['token' => '123abacu', 'username' => '[email protected]']);
 
         $this->assertSame(1, $user->getId());
+        $this->assertSame($payload, $google_authorizer->getUserProfile());
     }
 
     private function ensureTokenVerificationResult($token, $results)

test/src/RequestProcessorTest.php

@@ -0,0 +1,32 @@
+<?php
+
+namespace ActiveCollab\Authentication\Test;
+
+use ActiveCollab\Authentication\Authorizer\RequestProcessor\RequestProcessingResult\RequestProcessingResult;
+use ActiveCollab\Authentication\Test\TestCase\TestCase;
+
+/**
+ * @package ActiveCollab\Authentication\Test
+ */
+class RequestProcessorTest extends TestCase
+{
+    public function testDefaultPayloadIsNull()
+    {
+        $this->assertNull((new RequestProcessingResult([]))->getDefaultPayload());
+    }
+
+    public function testConstructRequestProcessingResult()
+    {
+        $credentials = [
+            'username' => 'me',
+            'password' => 'hard to guess, easy to remember',
+        ];
+
+        $payload = [1, 2, 3];
+
+        $result = new RequestProcessingResult($credentials, $payload);
+
+        $this->assertSame($credentials, $result->getCredentials());
+        $this->assertSame($payload, $result->getDefaultPayload());
+    }
+}