Remove by ref method signatures

Author: ilijastuden

composer.json

@@ -23,6 +23,7 @@
         "psr/http-server-middleware": "^1.0"
     },
     "require-dev": {
+        "ext-json": "*",
         "friendsofphp/php-cs-fixer": "^2.0",
         "lightsaml/lightsaml": "^1.1",
         "phpunit/phpunit": "^7.0",

src/LoginPolicy/LoginPolicy.php

@@ -92,7 +92,7 @@ public function getUsernameFormat()
     /**
      * {@inheritdoc}
      */
-    public function &setUsernameFormat($value)
+    public function setUsernameFormat($value)
     {
         if (in_array($value, self::VALID_USERNAME_FORMATS)) {
             $this->username_format = $value;
@@ -114,7 +114,7 @@ public function rememberExtendsSession()
     /**
      * {@inheritdoc}
      */
-    public function &setRememberExtendsSession($value)
+    public function setRememberExtendsSession($value)
     {
         $this->remember_extends_session = (bool) $value;
 
@@ -132,7 +132,7 @@ public function isPasswordChangeEnabled()
     /**
      * {@inheritdoc}
      */
-    public function &setIsPasswordChangeEnabled($value)
+    public function setIsPasswordChangeEnabled($value)
     {
         $this->password_change_enabled = (bool) $value;
 
@@ -150,7 +150,7 @@ public function isPasswordRecoveryEnabled()
     /**
      * {@inheritdoc}
      */
-    public function &setIsPasswordRecoveryEnabled($value)
+    public function setIsPasswordRecoveryEnabled($value)
     {
         $this->password_recovery_enabled = (bool) $value;
 
@@ -168,7 +168,7 @@ public function getExternalLoginUrl()
     /**
      * {@inheritdoc}
      */
-    public function &setExternalLoginUrl($value)
+    public function setExternalLoginUrl($value)
     {
         $this->external_login_url = $this->getValidExternalUrlValue($value);
 
@@ -186,7 +186,7 @@ public function getExternalLogoutUrl()
     /**
      * {@inheritdoc}
      */
-    public function &setExternalLogoutUrl($value)
+    public function setExternalLogoutUrl($value)
     {
         $this->external_logout_url = $this->getValidExternalUrlValue($value);
 
@@ -204,7 +204,7 @@ public function getExternalChangePasswordUrl()
     /**
      * {@inheritdoc}
      */
-    public function &setExternalChangePasswordUrl($value)
+    public function setExternalChangePasswordUrl($value)
     {
         $this->external_change_password_url = $this->getValidExternalUrlValue($value);
 
@@ -222,7 +222,7 @@ public function getExternalUpdateProfileUrl()
     /**
      * {@inheritdoc}
      */
-    public function &setExternalUpdateProfileUrl($value)
+    public function setExternalUpdateProfileUrl($value)
     {
         $this->external_update_profile_url = $this->getValidExternalUrlValue($value);
 

src/LoginPolicy/LoginPolicyInterface.php

@@ -33,7 +33,7 @@ public function getUsernameFormat();
      * @param  string $value
      * @return $this
      */
-    public function &setUsernameFormat($value);
+    public function setUsernameFormat($value);
 
     /**
      * Enable Remember Me feature to support extended sessions.
@@ -48,7 +48,7 @@ public function rememberExtendsSession();
      * @param  bool  $value
      * @return $this
      */
-    public function &setRememberExtendsSession($value);
+    public function setRememberExtendsSession($value);
 
     /**
      * Password change is supported by this authentication adapter.
@@ -63,7 +63,7 @@ public function isPasswordChangeEnabled();
      * @param  bool  $value
      * @return $this
      */
-    public function &setIsPasswordChangeEnabled($value);
+    public function setIsPasswordChangeEnabled($value);
 
     /**
      * Return true if this authentication adapter supports password recovery.
@@ -78,7 +78,7 @@ public function isPasswordRecoveryEnabled();
      * @param  bool  $value
      * @return $this
      */
-    public function &setIsPasswordRecoveryEnabled($value);
+    public function setIsPasswordRecoveryEnabled($value);
 
     /**
      * Get login URL.
@@ -93,7 +93,7 @@ public function getExternalLoginUrl();
      * @param  string $value
      * @return $this
      */
-    public function &setExternalLoginUrl($value);
+    public function setExternalLoginUrl($value);
 
     /**
      * Get logout URL.
@@ -108,7 +108,7 @@ public function getExternalLogoutUrl();
      * @param  string $value
      * @return $this
      */
-    public function &setExternalLogoutUrl($value);
+    public function setExternalLogoutUrl($value);
 
     /**
      * Get change password URL.
@@ -123,7 +123,7 @@ public function getExternalChangePasswordUrl();
      * @param  string $value
      * @return $this
      */
-    public function &setExternalChangePasswordUrl($value);
+    public function setExternalChangePasswordUrl($value);
 
     /**
      * Get update profile URL.
@@ -138,5 +138,5 @@ public function getExternalUpdateProfileUrl();
      * @param  string $value
      * @return $this
      */
-    public function &setExternalUpdateProfileUrl($value);
+    public function setExternalUpdateProfileUrl($value);
 }

test/src/Session/Session.php

@@ -101,7 +101,7 @@ public function getIsExtendedSession()
      * @param  bool  $value
      * @return $this
      */
-    public function &setIsExtendedSession($value)
+    public function setIsExtendedSession($value)
     {
         $this->is_extended_session = (bool) $value;
 

test/src/Token/Token.php

@@ -78,7 +78,7 @@ public function getExtraAttribute()
      * @param  mixed $value
      * @return $this
      */
-    public function &setExtraAttribute($value)
+    public function setExtraAttribute($value)
     {
         $this->extra_attribute = $value;