Improve tests and Travis CI fix

Author: ilijastuden

.travis.yml

@@ -1,6 +1,6 @@
 language: php
 php:
-  - 7.3
+  - 7.4
 before_install:
   - composer self-update
 install: composer install --dev

composer.json

@@ -28,8 +28,7 @@
         "lightsaml/lightsaml": "^1.1",
         "phpunit/phpunit": "^9.0",
         "satooshi/php-coveralls": "^1.0",
-        "laminas/laminas-diactoros": "^2.0",
-        "pimple/pimple": "^3.2"
+        "laminas/laminas-diactoros": "^2.0"
     },
     "suggest": {
         "lightsaml/lightsaml": "If you want to use SAML authentication you should manually install this package."

composer.lock

@@ -40,29 +40,35 @@ public function testValidUsernameFormat()
         );
     }
 
-//    /**
-//     * Test if flags are properly cast to boolean values.
-//     */
-//    public function testFlagsAreCasterToBool()
-//    {
-//        $this->assertSame(true, (new LoginPolicy())->setRememberExtendsSession('1')->rememberExtendsSession());
-//        $this->assertSame(true, (new LoginPolicy())->setIsPasswordChangeEnabled(1)->isPasswordChangeEnabled());
-//        $this->assertSame(true, (new LoginPolicy())->setIsPasswordRecoveryEnabled('YES')->isPasswordRecoveryEnabled());
-//
-//        $this->assertSame(false, (new LoginPolicy())->setRememberExtendsSession('0')->rememberExtendsSession());
-//        $this->assertSame(false, (new LoginPolicy())->setIsPasswordChangeEnabled(0)->isPasswordChangeEnabled());
-//        $this->assertSame(false, (new LoginPolicy())->setIsPasswordRecoveryEnabled('0')->isPasswordRecoveryEnabled());
-//    }
-
     /**
      * Test if system accepts URLs or NULL.
      */
     public function testValidUrlsOrNull()
     {
-        $this->assertSame('https://www.activecollab.com/login', (new LoginPolicy())->setExternalLoginUrl('https://www.activecollab.com/login')->getExternalLoginUrl());
-        $this->assertSame('https://www.activecollab.com/logout', (new LoginPolicy())->setExternalLogoutUrl('https://www.activecollab.com/logout')->getExternalLogoutUrl());
-        $this->assertSame('https://www.activecollab.com/password', (new LoginPolicy())->setExternalChangePasswordUrl('https://www.activecollab.com/password')->getExternalChangePasswordUrl());
-        $this->assertSame('https://www.activecollab.com/profile', (new LoginPolicy())->setExternalUpdateProfileUrl('https://www.activecollab.com/profile')->getExternalUpdateProfileUrl());
+        $this->assertSame(
+            'https://www.activecollab.com/login',
+            (new LoginPolicy())
+                ->setExternalLoginUrl('https://www.activecollab.com/login')
+                    ->getExternalLoginUrl()
+        );
+        $this->assertSame(
+            'https://www.activecollab.com/logout',
+            (new LoginPolicy())
+                ->setExternalLogoutUrl('https://www.activecollab.com/logout')
+                    ->getExternalLogoutUrl()
+        );
+        $this->assertSame(
+            'https://www.activecollab.com/password',
+            (new LoginPolicy())
+                ->setExternalChangePasswordUrl('https://www.activecollab.com/password')
+                    ->getExternalChangePasswordUrl()
+        );
+        $this->assertSame(
+            'https://www.activecollab.com/profile',
+            (new LoginPolicy())
+                ->setExternalUpdateProfileUrl('https://www.activecollab.com/profile')
+                    ->getExternalUpdateProfileUrl()
+        );
 
         $this->assertNull((new LoginPolicy())->setExternalLoginUrl(null)->getExternalLoginUrl());
         $this->assertNull((new LoginPolicy())->setExternalLogoutUrl(null)->getExternalLogoutUrl());