Merge branch 'main' into cleanup-multitrackparams

Author: kodiakhq[bot]

.github/workflows/builds.yml

@@ -20,6 +20,7 @@ env:
   CCACHE_DIR: ${{ github.workspace }}/ccache
   CCACHE_MAXSIZE: 500M
   CCACHE_KEY_SUFFIX: r2
+  ACTS_SEQUENCER_FAIL_ON_UNMASKED_FPE: 0
 
 jobs:
   linux_ubuntu:
@@ -120,7 +121,7 @@ jobs:
     container: ghcr.io/acts-project/ubuntu2404:83
     needs: [linux_ubuntu]
     env:
-      ACTS_SEQUENCER_DISABLE_FPEMON: true
+      ACTS_SEQUENCER_FAIL_ON_UNMASKED_FPE: 0
 
     steps:
       - uses: actions/checkout@v6
@@ -158,8 +159,6 @@ jobs:
     runs-on: ubuntu-latest
     container: ghcr.io/acts-project/ubuntu2404:83
     needs: [linux_ubuntu]
-    env:
-      ACTS_SEQUENCER_DISABLE_FPEMON: true
 
     steps:
       - uses: actions/checkout@v6

.gitlab-ci.yml

@@ -395,8 +395,7 @@ linux_ubuntu_2404_clang19:
 
   variables:
     ACTS_LOG_FAILURE_THRESHOLD: WARNING
-    # disable fpe monitoring as we can't mask without backtrace support
-    ACTS_SEQUENCER_DISABLE_FPEMON: true
+    ACTS_SEQUENCER_FAIL_ON_UNMASKED_FPE: 0
     INSTALL_DIR: ${CI_PROJECT_DIR}/install
     # force off even if it is CI mode
     ROOT_HASH_CHECKS: off

.pre-commit-config.yaml

@@ -31,15 +31,15 @@ repos:
       args: ["-i", "--no-warn-about-unknown-commands"]
 
   - repo: https://github.com/codespell-project/codespell
-    rev: v2.2.4
+    rev: v2.4.2
     hooks:
     - id: codespell
       args: [
         "-S", "*.ipynb,*.onnx,_build,*.svg",
         "-I", "./CI/codespell_ignore.txt",
         "-w"
       ]
-      exclude: ^CI/.*|docs/tex-mml-chtml.js$
+      exclude: ^CI/.*|^docs/old|docs/tex-mml-chtml.js$
 
   - repo: local
     hooks:

CI/clang_tidy/requirements.txt

@@ -30,7 +30,7 @@ pyyaml==6.0.3
     # via -r CI/clang_tidy/requirements.in
 rich==14.3.3
     # via -r CI/clang_tidy/requirements.in
-setuptools==82.0.0
+setuptools==82.0.1
     # via fs
 six==1.17.0
     # via fs

CI/codespell_ignore.txt

@@ -3,23 +3,31 @@ ans
 boxs
 bu
 coner
+countin
 dependees
 dthe
 ect
+estimater
 exprot
 gaus
+hep
 interprete
 iself
 lastr
 localy
 millepede
+parin
 parm
+patchin
 pixelx
 pring
+rin
 sortings
 strack
 te
+tge
+transformin
 vart
 writet
-OptionA
+optiona
 thirdparty

CI/fpe_masks/requirements.txt

@@ -40,7 +40,7 @@ pycparser==3.0
     # via cffi
 pygments==2.19.2
     # via rich
-pyjwt==2.11.0
+pyjwt==2.12.1
     # via gidgethub
 rich==14.3.3
     # via

CMakeLists.txt

@@ -108,10 +108,10 @@ option(ACTS_BUILD_EXAMPLES "Build basic examples components" OFF)
 option(ACTS_BUILD_EXAMPLES_DD4HEP "Build DD4hep-based code in the examples" OFF)
 option(ACTS_BUILD_EXAMPLES_EDM4HEP "Build EDM4hep-based code in the examples" OFF)
 option(ACTS_BUILD_EXAMPLES_FASTJET "Build FastJet plugin" OFF)
-option(ACTS_BUILD_EXAMPLES_PODIO "Build Podio-based code in the examples" OFF)
-option(ACTS_BUILD_EXAMPLES_GNN "Build the GNN example code" OFF)
 option(ACTS_BUILD_EXAMPLES_GEANT4 "Build Geant4-based code in the examples" OFF)
+option(ACTS_BUILD_EXAMPLES_GNN "Build the GNN example code" OFF)
 option(ACTS_BUILD_EXAMPLES_HASHING "Build Hashing-based code in the examples" OFF)
+option(ACTS_BUILD_EXAMPLES_PODIO "Build Podio-based code in the examples" OFF)
 option(ACTS_BUILD_EXAMPLES_PYTHIA8 "Build Pythia8-based code in the examples" OFF)
 option(ACTS_BUILD_EXAMPLES_PYTHON_BINDINGS "[Deprecated] Build python bindings and enables the examples" OFF)
 option(ACTS_BUILD_EXAMPLES_ROOT "Build modules based on ROOT I/O" OFF)
@@ -161,15 +161,21 @@ set_option_if(
     OR
     ACTS_BUILD_EXAMPLES_EDM4HEP
     OR
+    ACTS_BUILD_EXAMPLES_FASTJET
+    OR
     ACTS_BUILD_EXAMPLES_GEANT4
     OR
+    ACTS_BUILD_EXAMPLES_GNN
+    OR
     ACTS_BUILD_EXAMPLES_HASHING
     OR
-    ACTS_BUILD_EXAMPLES_PYTHIA8
+    ACTS_BUILD_EXAMPLES_PODIO
     OR
-    ACTS_BUILD_EXAMPLES_GNN
+    ACTS_BUILD_EXAMPLES_PYTHIA8
     OR
     ACTS_BUILD_EXAMPLES_PYTHON_BINDINGS
+    OR
+    ACTS_BUILD_EXAMPLES_ROOT
 )
 # core plugins might be required by examples or depend on each other
 set_option_if(

CMakePresets.json

@@ -59,6 +59,7 @@
                 "ACTS_BUILD_PLUGIN_ACTSVG": "ON",
                 "ACTS_BUILD_PLUGIN_DD4HEP": "ON",
                 "ACTS_BUILD_PLUGIN_EDM4HEP": "ON",
+                "ACTS_BUILD_PLUGIN_FPEMON": "ON",
                 "ACTS_BUILD_PLUGIN_GEOMODEL": "ON",
                 "ACTS_BUILD_PLUGIN_TRACCC": "ON",
                 "ACTS_BUILD_PLUGIN_GEANT4": "ON",
@@ -110,8 +111,7 @@
             "displayName": "GitLab-CI",
             "inherits": "ci-common",
             "cacheVariables": {
-                "CMAKE_BUILD_TYPE": "RelWithDebInfo",
-                "ACTS_BUILD_PLUGIN_FPEMON": "ON"
+                "CMAKE_BUILD_TYPE": "RelWithDebInfo"
             }
         },
         {
@@ -148,6 +148,7 @@
                 "ACTS_FORCE_ASSERTIONS": "ON",
                 "ACTS_ENABLE_LOG_FAILURE_THRESHOLD": "ON",
                 "ACTS_BUILD_PYTHON_BINDINGS": "ON",
+                "ACTS_BUILD_PLUGIN_FPEMON": "ON",
                 "ACTS_BUILD_PLUGIN_GNN": "ON",
                 "ACTS_BUILD_EXAMPLES": "ON",
                 "ACTS_BUILD_EXAMPLES_GNN": "ON",
@@ -168,6 +169,7 @@
                 "CMAKE_CXX_COMPILER_LAUNCHER": "ccache",
                 "CMAKE_CUDA_ARCHITECTURES": "86",
                 "TORCH_CUDA_ARCH_LIST": "8.6",
+                "ACTS_BUILD_PLUGIN_FPEMON": "ON",
                 "ACTS_BUILD_PLUGIN_GNN": "ON",
                 "ACTS_GNN_ENABLE_TORCH": "OFF",
                 "ACTS_GNN_ENABLE_CUDA": "ON",
@@ -192,7 +194,7 @@
                 "ACTS_BUILD_PYTHON_BINDINGS": "ON",
                 "ACTS_BUILD_EXAMPLES": "ON",
                 "ACTS_BUILD_PLUGIN_ROOT": "OFF",
-                "ACTS_BUILD_PLUGIN_FPEMON": "OFF",
+                "ACTS_BUILD_PLUGIN_FPEMON": "ON",
                 "ACTS_BUILD_EXAMPLES_ROOT": "OFF",
                 "ACTS_USE_SYSTEM_NLOHMANN_JSON": "ON",
                 "ACTS_USE_SYSTEM_PYBIND11": "ON"

Core/include/Acts/Geometry/DetectorElementBase.hpp

@@ -20,6 +20,7 @@
 
 #include <algorithm>
 #include <array>
+#include <functional>
 #include <set>
 #include <string>
 #include <vector>
@@ -100,7 +101,7 @@ void applyReferenceExpansion(
 /// bin in between the extra points are filled, and a possible expansion
 /// of the bin window can be chosen
 ///
-/// @tparam grid_type the type of the grid that determines locall binning
+/// @tparam grid_type the type of the grid that determines local binning
 ///
 /// @param grid the grid used for this
 /// @param queries the grid positions for the bin queries
@@ -233,17 +234,38 @@ class IndexGrid {
   /// These are the cast parameters - copied from constructor
   std::array<AxisDirection, grid_type::DIM> casts{};
 
-  /// A transform to be applied to the position
-  Transform3 transform = Transform3::Identity();
+  /// Abrivation of the delegate to transform the
+  /// external point into the grid's coordinate system
+  using Delegate_t =
+      std::function<const Transform3&(const GeometryContext& gctx)>;
 
-  /// @brief  Constructor for a grid based surface attacher
+  /// Delegate to transform the external points into the grid's
+  /// coordinate system
+  Delegate_t toLocalFrame = nullptr;
+
+  /// Constructor for a grid based surface attacher
   /// @param igrid the grid that is moved into this attacher
   /// @param icasts is the cast values array
   /// @param itr a transform applied to the global position
   IndexGrid(grid_type&& igrid,
             const std::array<AxisDirection, grid_type::DIM>& icasts,
             const Transform3& itr = Transform3::Identity())
-      : grid(std::move(igrid)), casts(icasts), transform(itr) {}
+      : grid{std::move(igrid)},
+        casts{icasts},
+        toLocalFrame{
+            [itr](const GeometryContext& /*gctx*/) -> const Transform3& {
+              return itr;
+            }} {}
+  /// Constructor for a grid based surface attacher with alignable delegate
+  /// @param igrid the grid that is moved into this attacher
+  /// @param icasts is the cast values array
+  /// @param trfFunc a transform applied to the global position
+  IndexGrid(grid_type&& igrid,
+            const std::array<AxisDirection, grid_type::DIM>& icasts,
+            Delegate_t trfFunc)
+      : grid{std::move(igrid)},
+        casts{icasts},
+        toLocalFrame{std::move(trfFunc)} {}
 
   IndexGrid() = delete;
 };
@@ -299,7 +321,7 @@ struct IndexGridFiller {
         // Cast the transform according to the grid binning
         gridQueries.push_back(
             GridAccessHelpers::castPosition<decltype(iGrid.grid)>(
-                iGrid.transform * ref, iGrid.casts));
+                iGrid.toLocalFrame(gctx) * ref, iGrid.casts));
       }
       ACTS_DEBUG(gridQueries.size() << " reference points generated.");
       // These are now in the grid frame, can be expanded