Skip to content

Commit 96a3128

Browse files
authored
Fix mobile budget amount inputs when hide decimal places is enabled (#6945)
1 parent 003efec commit 96a3128

File tree

5 files changed

+18
-6
lines changed

5 files changed

+18
-6
lines changed

packages/desktop-client/src/components/mobile/transactions/TransactionEdit.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -460,7 +460,7 @@ const ChildTransactionEdit = forwardRef<
460460
onClearActiveEdit();
461461
}
462462
}}
463-
autoDecimals={!hideFraction}
463+
autoDecimals={String(hideFraction) !== 'true'}
464464
/>
465465
</View>
466466
</View>

packages/desktop-client/src/components/modals/CoverModal.tsx

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@ import {
2424
import { AmountInput } from '@desktop-client/components/util/AmountInput';
2525
import { useCategories } from '@desktop-client/hooks/useCategories';
2626
import { useInitialMount } from '@desktop-client/hooks/useInitialMount';
27+
import { useSyncedPref } from '@desktop-client/hooks/useSyncedPref';
2728
import { pushModal } from '@desktop-client/modals/modalsSlice';
2829
import type { Modal as ModalType } from '@desktop-client/modals/modalsSlice';
2930
import { useDispatch } from '@desktop-client/redux';
@@ -39,6 +40,7 @@ export function CoverModal({
3940
onSubmit,
4041
}: CoverModalProps) {
4142
const { t } = useTranslation();
43+
const [hideFraction] = useSyncedPref('hideFraction');
4244

4345
const { data: { grouped: originalCategoryGroups } = { grouped: [] } } =
4446
useCategories();
@@ -107,7 +109,7 @@ export function CoverModal({
107109
<InitialFocus>
108110
<AmountInput
109111
value={amount}
110-
autoDecimals
112+
autoDecimals={String(hideFraction) !== 'true'}
111113
style={{
112114
marginLeft: styles.mobileEditingPadding,
113115
marginRight: styles.mobileEditingPadding,

packages/desktop-client/src/components/modals/HoldBufferModal.tsx

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ import {
1414
} from '@desktop-client/components/common/Modal';
1515
import { FieldLabel } from '@desktop-client/components/mobile/MobileForms';
1616
import { AmountInput } from '@desktop-client/components/util/AmountInput';
17+
import { useSyncedPref } from '@desktop-client/hooks/useSyncedPref';
1718
import type { Modal as ModalType } from '@desktop-client/modals/modalsSlice';
1819
import { envelopeBudget } from '@desktop-client/spreadsheet/bindings';
1920

@@ -24,6 +25,7 @@ type HoldBufferModalProps = Extract<
2425

2526
export function HoldBufferModal({ onSubmit }: HoldBufferModalProps) {
2627
const { t } = useTranslation(); // Initialize i18next
28+
const [hideFraction] = useSyncedPref('hideFraction');
2729
const available = useEnvelopeSheetValue(envelopeBudget.toBudget) ?? 0;
2830
const [amount, setAmount] = useState<number>(0);
2931

@@ -49,8 +51,8 @@ export function HoldBufferModal({ onSubmit }: HoldBufferModalProps) {
4951
<FieldLabel title={t('Hold this amount:')} />{' '}
5052
<InitialFocus>
5153
<AmountInput
52-
value={available}
53-
autoDecimals
54+
value={amount}
55+
autoDecimals={String(hideFraction) !== 'true'}
5456
zeroSign="+"
5557
style={{
5658
marginLeft: styles.mobileEditingPadding,

packages/desktop-client/src/components/modals/TransferModal.tsx

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@ import {
2323
} from '@desktop-client/components/mobile/MobileForms';
2424
import { AmountInput } from '@desktop-client/components/util/AmountInput';
2525
import { useCategories } from '@desktop-client/hooks/useCategories';
26+
import { useSyncedPref } from '@desktop-client/hooks/useSyncedPref';
2627
import { pushModal } from '@desktop-client/modals/modalsSlice';
2728
import type { Modal as ModalType } from '@desktop-client/modals/modalsSlice';
2829
import { useDispatch } from '@desktop-client/redux';
@@ -38,6 +39,7 @@ export function TransferModal({
3839
onSubmit,
3940
}: TransferModalProps) {
4041
const { t } = useTranslation();
42+
const [hideFraction] = useSyncedPref('hideFraction');
4143

4244
const { data: { grouped: originalCategoryGroups } = { grouped: [] } } =
4345
useCategories();
@@ -99,8 +101,8 @@ export function TransferModal({
99101
<FieldLabel title={t('Transfer this amount:')} />
100102
<InitialFocus>
101103
<AmountInput
102-
value={initialAmount}
103-
autoDecimals
104+
value={amount}
105+
autoDecimals={String(hideFraction) !== 'true'}
104106
style={{
105107
marginLeft: styles.mobileEditingPadding,
106108
marginRight: styles.mobileEditingPadding,

upcoming-release-notes/6945.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
---
2+
category: Bugfixes
3+
authors: [piyush-1337]
4+
---
5+
6+
Fix mobile budget amount inputs when hide decimal places is enabled

0 commit comments

Comments
 (0)