Rename loot-core/platform/client/fetch to connection to match server-side package (#6943)

* Rename loot-core/platform/client/fetch package to connection to match the server side package name. Also to avoid confusion with the native fetch package.

* Update connection/init method to not receive any parameter to so browser and default implementation have the same signature

* Add release notes for PR #6943

* Fix names

* Fix imports

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

Author: joel-jeremy

packages/desktop-client/src/accounts/accountsSlice.ts

@@ -2,7 +2,7 @@ import { createSlice } from '@reduxjs/toolkit';
 import type { PayloadAction } from '@reduxjs/toolkit';
 import memoizeOne from 'memoize-one';
 
-import { send } from 'loot-core/platform/client/fetch';
+import { send } from 'loot-core/platform/client/connection';
 import type { SyncResponseWithErrors } from 'loot-core/server/accounts/app';
 import { groupById } from 'loot-core/shared/util';
 import type {

packages/desktop-client/src/app/appSlice.ts

@@ -1,7 +1,7 @@
 import { createAction, createSlice } from '@reduxjs/toolkit';
 import type { PayloadAction } from '@reduxjs/toolkit';
 
-import { send } from 'loot-core/platform/client/fetch';
+import { send } from 'loot-core/platform/client/connection';
 import { getUploadError } from 'loot-core/shared/errors';
 import type { AccountEntity } from 'loot-core/types/models';
 import type { AtLeastOne } from 'loot-core/types/util';

packages/desktop-client/src/budget/mutations.ts

@@ -5,8 +5,8 @@ import type { QueryClient, QueryKey } from '@tanstack/react-query';
 import type { TFunction } from 'i18next';
 import { v4 as uuidv4 } from 'uuid';
 
-import { sendCatch } from 'loot-core/platform/client/fetch';
-import type { send } from 'loot-core/platform/client/fetch';
+import { sendCatch } from 'loot-core/platform/client/connection';
+import type { send } from 'loot-core/platform/client/connection';
 import { logger } from 'loot-core/platform/server/log';
 import type { IntegerAmount } from 'loot-core/shared/util';
 import type {

packages/desktop-client/src/budget/queries.ts

@@ -1,7 +1,7 @@
 import { queryOptions } from '@tanstack/react-query';
 import i18n from 'i18next';
 
-import { send } from 'loot-core/platform/client/fetch';
+import { send } from 'loot-core/platform/client/connection';
 import type {
   CategoryEntity,
   CategoryGroupEntity,

packages/desktop-client/src/budgetfiles/budgetfilesSlice.ts

@@ -2,7 +2,7 @@ import { createSlice } from '@reduxjs/toolkit';
 import type { PayloadAction } from '@reduxjs/toolkit';
 import { t } from 'i18next';
 
-import { send } from 'loot-core/platform/client/fetch';
+import { send } from 'loot-core/platform/client/connection';
 import type { RemoteFile } from 'loot-core/server/cloud-storage';
 import { getDownloadError, getSyncError } from 'loot-core/shared/errors';
 import type { Budget } from 'loot-core/types/budget';

packages/desktop-client/src/components/App.tsx

@@ -12,7 +12,10 @@ import { styles } from '@actual-app/components/styles';
 import { View } from '@actual-app/components/view';
 import { useQueryClient } from '@tanstack/react-query';
 
-import { init as initConnection, send } from 'loot-core/platform/client/fetch';
+import {
+  init as initConnection,
+  send,
+} from 'loot-core/platform/client/connection';
 
 import { AppBackground } from './AppBackground';
 import { BudgetMonthCountProvider } from './budget/BudgetMonthCountContext';
@@ -73,18 +76,15 @@ function AppInner() {
     };
 
     async function init() {
-      const serverSocket = await maybeUpdate(() =>
-        global.Actual.getServerSocket(),
-      );
-
+      await maybeUpdate();
       dispatch(
         setAppState({
           loadingText: t(
             'Initializing the connection to the local database...',
           ),
         }),
       );
-      await initConnection(serverSocket);
+      await initConnection();
 
       // Load any global prefs
       dispatch(

packages/desktop-client/src/components/LoggedInUser.tsx

@@ -11,7 +11,7 @@ import { Text } from '@actual-app/components/text';
 import { theme } from '@actual-app/components/theme';
 import { View } from '@actual-app/components/view';
 
-import { listen } from 'loot-core/platform/client/fetch';
+import { listen } from 'loot-core/platform/client/connection';
 import type { RemoteFile, SyncedLocalFile } from 'loot-core/types/file';
 import type { TransObjectLiteral } from 'loot-core/types/util';
 

packages/desktop-client/src/components/ManageRules.tsx

@@ -10,7 +10,7 @@ import { Text } from '@actual-app/components/text';
 import { theme } from '@actual-app/components/theme';
 import { View } from '@actual-app/components/view';
 
-import { send } from 'loot-core/platform/client/fetch';
+import { send } from 'loot-core/platform/client/connection';
 import * as undo from 'loot-core/platform/client/undo';
 import { getNormalisedString } from 'loot-core/shared/normalisation';
 import { q } from 'loot-core/shared/query';

packages/desktop-client/src/components/Modals.tsx

@@ -2,7 +2,7 @@
 import React, { Fragment, useEffect, useEffectEvent } from 'react';
 import { useLocation } from 'react-router';
 
-import { send } from 'loot-core/platform/client/fetch';
+import { send } from 'loot-core/platform/client/connection';
 import * as monthUtils from 'loot-core/shared/months';
 
 import { EditSyncAccount } from './banksync/EditSyncAccount';

packages/desktop-client/src/components/NotesButton.tsx

@@ -10,7 +10,7 @@ import { Tooltip } from '@actual-app/components/tooltip';
 import { View } from '@actual-app/components/view';
 import { css, cx } from '@emotion/css';
 
-import { send } from 'loot-core/platform/client/fetch';
+import { send } from 'loot-core/platform/client/connection';
 
 import { Notes } from './Notes';