🚨 add lint

Author: ad2ien

.github/workflows/build.yml

@@ -13,6 +13,9 @@ jobs:
     steps:
       - uses: actions/checkout@v4
 
+      - name: lint
+        uses: golangci/golangci-lint-action@v8
+
       - name: Set up Docker Buildx
         uses: docker/setup-buildx-action@v3
 

.gitignore

@@ -1,4 +1,5 @@
 .env
 build/
 *.db
-help-the-stars
+help-the-stars
+.cache/

README.md

@@ -74,7 +74,3 @@ Create migration
 ```bash
 docker run -v $(pwd)/migrations:/migrations --network host migrate/migrate -path=/migrations -database "sqlite://db/help-the-stars.db" create -ext sql -dir /migrations -seq MIGRATION_NAME
 ```
-
-## TODO
-
-- [ ] lint go/docker

internal/datacontroller.go

@@ -74,7 +74,11 @@ func (d *DataController) Worker() {
 
 func (d *DataController) GetAndSaveIssues() {
 
-	d.queries.TaskDataInProgress(d.ctx)
+	err := d.queries.TaskDataInProgress(d.ctx)
+
+	if err != nil {
+		log.Fatal(err)
+	}
 
 	log.Info("Loading issues...")
 	data, err := GetStaredRepos(50)
@@ -86,7 +90,10 @@ func (d *DataController) GetAndSaveIssues() {
 
 	for i := 0; i < len(expired); i++ {
 		log.Info("Delete an issue ", expired[i].Url)
-		d.queries.DeleteIssue(d.ctx, expired[i].Url)
+		delErr := d.queries.DeleteIssue(d.ctx, expired[i].Url)
+		if delErr != nil {
+			log.Error("Error deleting issue", delErr)
+		}
 	}
 
 	if d.matrixClient != nil {
@@ -99,8 +106,12 @@ func (d *DataController) GetAndSaveIssues() {
 	for i := 0; i < len(data); i++ {
 
 		log.Info("Save an issue ", data[i].Url)
-		d.queries.CreateIssue(d.ctx,
+		_, createErr := d.queries.CreateIssue(d.ctx,
 			mapModelToDbParameter(data[i]))
+
+		if createErr != nil {
+			log.Error("Error creating issue", createErr)
+		}
 	}
 
 	err = d.queries.UpdateTimeTaskData(d.ctx, sql.NullTime{Time: time.Now(), Valid: true})

internal/dbConnection.go

@@ -3,7 +3,6 @@ package internal
 import (
 	"database/sql"
 	"embed"
-	_ "embed"
 	"fmt"
 	"net/http"
 
@@ -44,7 +43,10 @@ func NewConnection(migrationsFs embed.FS) DbConnection {
 }
 
 func (dbConn *DbConnection) Close() {
-	dbConn.Connection.Close()
+	err := dbConn.Connection.Close()
+	if err != nil {
+		log.Error("error closing connection", err)
+	}
 }
 
 func ensureSchema(migrations embed.FS, db *sql.DB) error {

internal/mapperUtil.go

@@ -9,8 +9,7 @@ func mapGhQueryToHelpWantedIssue(query GhQuery) []HelpWantedIssue {
 	var helpLookingIssues []HelpWantedIssue
 
 	for _, repo := range query.Viewer.StarredRepositories.Nodes {
-		if repo.Issues.Nodes == nil ||
-			len(repo.Issues.Nodes) == 0 {
+		if len(repo.Issues.Nodes) == 0 {
 			continue
 		}
 		for _, issue := range repo.Issues.Nodes {

internal/matrixNotif.go

@@ -11,8 +11,7 @@ import (
 )
 
 type MatrixClient struct {
-	client    *mautrix.Client
-	respLogin *mautrix.RespLogin
+	client *mautrix.Client
 }
 
 func CreateMatrixClient() *MatrixClient {

lint.sh

@@ -0,0 +1,8 @@
+# -v $(go env GOCACHE):/.cache/go-build -e GOCACHE=/.cache/go-build \
+# -v $(go env GOMODCACHE):/.cache/mod -e GOMODCACHE=/.cache/mod \
+# --user $(id -u):$(id -g) \
+docker run --rm -t -v $(pwd):/app -w /app \
+-v ./.cache/go-build:/.cache/go-build -e GOCACHE=/.cache/go-build \
+-v ./.cache/mod:/.cache/mod -e GOMODCACHE=/.cache/mod \
+-v ./.cache/golangci-lint:/.cache/golangci-lint -e GOLANGCI_LINT_CACHE=/.cache/golangci-lint \
+golangci/golangci-lint:v2.4.0 golangci-lint run

main.go

@@ -46,5 +46,9 @@ func main() {
 	http.HandleFunc("/", webpageHandler.HandleWebPage)
 
 	log.Info("Server listening on port 1983")
-	http.ListenAndServe(":1983", nil)
+	err := http.ListenAndServe(":1983", nil)
+
+	if err != nil {
+		log.Error("Server error", err)
+	}
 }