Skip to content

Commit 8139b3f

Browse files
authored
Codspeed: fix WPT benchmark (#1038)
1 parent 52be58d commit 8139b3f

File tree

2 files changed

+12
-8
lines changed

2 files changed

+12
-8
lines changed

benchmarks/benchmark_template.cpp

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,7 @@ size_t count_whatwg_invalid() {
186186
}
187187

188188
template <bool just_parse = false>
189-
static void BasicBench_whatwg(benchmark::State& state) {
189+
static void BENCHMARK_NAME(BasicBench_whatwg)(benchmark::State& state) {
190190
// volatile to prevent optimizations.
191191
volatile size_t success = 0;
192192
volatile size_t href_size = 0;
@@ -248,7 +248,10 @@ static void BasicBench_whatwg(benchmark::State& state) {
248248
state.counters["url/s"] = benchmark::Counter(
249249
std::size(url_examples), benchmark::Counter::kIsIterationInvariantRate);
250250
}
251-
BENCHMARK(BasicBench_whatwg);
251+
static auto* CONCAT(benchmark_register_, BENCHMARK_NAME(BasicBench_whatwg)) =
252+
::benchmark::RegisterBenchmark(BENCHMARK_PREFIX_STR "BasicBench_whatwg",
253+
BENCHMARK_NAME(BasicBench_whatwg));
254+
252255
// There is no need for BasicBench_whatwg_just_parse because whatwg appears to
253256
// provide the href at a minimal cost, probably because it is already
254257
// materialized. auto BasicBench_whatwg_just_parse =

benchmarks/wpt_bench.cpp

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -144,16 +144,17 @@ static void BasicBench_AdaURL(benchmark::State &state) {
144144
benchmark::Counter(double(std::size(url_examples)),
145145
benchmark::Counter::kIsIterationInvariantRate);
146146
}
147-
auto BasicBench_AdaURL_url = BasicBench_AdaURL<ada::url>;
148-
BENCHMARK(BasicBench_AdaURL_url);
149-
auto BasicBench_AdaURL_url_aggregator = BasicBench_AdaURL<ada::url_aggregator>;
150-
BENCHMARK(BasicBench_AdaURL_url_aggregator);
147+
auto WptBench_BasicBench_AdaURL_url = BasicBench_AdaURL<ada::url>;
148+
BENCHMARK(WptBench_BasicBench_AdaURL_url);
149+
auto WptBench_BasicBench_AdaURL_url_aggregator =
150+
BasicBench_AdaURL<ada::url_aggregator>;
151+
BENCHMARK(WptBench_BasicBench_AdaURL_url_aggregator);
151152

152153
#if ADA_url_whatwg_ENABLED
153154

154155
#include <upa/url.h>
155156

156-
static void BasicBench_whatwg(benchmark::State &state) {
157+
static void WptBench_BasicBench_whatwg(benchmark::State &state) {
157158
volatile size_t success{};
158159
for (auto _ : state) {
159160
for (const std::pair<std::string, std::string> &url_strings :
@@ -224,7 +225,7 @@ static void BasicBench_whatwg(benchmark::State &state) {
224225
benchmark::Counter(double(std::size(url_examples)),
225226
benchmark::Counter::kIsIterationInvariantRate);
226227
}
227-
BENCHMARK(BasicBench_whatwg);
228+
BENCHMARK(WptBench_BasicBench_whatwg);
228229
#endif // ADA_url_whatwg_ENABLED
229230

230231
int main(int argc, char **argv) {

0 commit comments

Comments
 (0)