RP2 Port Uses RP2040 Headers for RP2350 Builds

[eightycc]

The Pico SDK has headers common to the RP2040 and RP2350 as well as headers specific to these processors. In some cases, CP RP2 port code includes RP2040-specific headers unconditionally. For example, common_hal/rp2pio/StateMachine.c included src/rp2040/hardware_regs/include/hardware/platform_defs.h causing it to miss the third PIO available on the RP2350.

RP2 port code needs to be examined for other instances of this problem.

[dhalbert]

Thank you for finding this!

Another related thing to watch out for:
#define PICO_RP2350A 1 means compile for the RP2350A chip.
#define PICO_RP2350A 0 means compile for the RP2350B chip. There is noPICO_RP2350B right now (!).

This might get fixed soon: raspberrypi/pico-sdk#2364 and earlephilhower/arduino-pico#2878.

[eightycc]

Thanks for pointing that out. Also related is #10141.

[eightycc]

@jepler notes: ...a comprehensive fix (would probably be to add the correct -isystem or -I compiler flags so that the header can be included as hardware/platform_defs.h etc.

Agree completely.