This repository was archived by the owner on May 11, 2021. It is now read-only.
This repository was archived by the owner on May 11, 2021. It is now read-only.
Merge outstanding pull requests from disqus/gargoyle #12
Open
Description
Currently open PRs and judgment:
- Condition rename: myapp/gargoyle.py shadows gargoyle package disqus/gargoyle#3 Condition rename: myapp/gargoyle.py shadows gargoyle package
❌ Should be closed, just anabsolute_import
issue - Add session specific controls to dashboard so that users who have permiss disqus/gargoyle#13 Add session specific controls to dashboard so that users who have permiss
Possibly useful, but it's a major feature and has no extra +1 requests/subscribers so likely not wanted by many - Added Jinja template tag disqus/gargoyle#17 Added Jinja template tag
Probably useful but likely to need signficant reworking to work with Django's new Jinja template engine. - add is_active stringfilter disqus/gargoyle#32 add is_active stringfilter
Good idea but should rename it or figure out a way of adding a variable to the context. - add SwitchActiveMixin to check for gargoyle switch disqus/gargoyle#43 add SwitchActiveMixin to check for gargoyle switch
LGTM, but no upvotes. - Fixed range condition disqus/gargoyle#55 Fixed range condition
✅ We have merged in Update gargoyle/conditions.py #22. - Wrap id's of selectors in quotes disqus/gargoyle#73 Wrap id's of selectors in quotes
✅ We have merged in Wrap id's of selectors in quotes #34 , with nexus jQuery upgrade merged in Upgrade jQuery to 1.6.4 nexus#43. - Add ifnotswitch template tag disqus/gargoyle#92 Add ifnotswitch template tag
✅ We have merged in Add ifnotswitch template tag #37. - Cannot add conditions in Nexus disqus/gargoyle#98 Cannot add conditions in Nexus
✅ We fixed the issue rather than merge the documentation update. Wrap id's of selectors in quotes #34 fixed some of the problems with spaces, Fix Nexus admin interface for Switches with spaces in their keys #38 fixed the remainder. - throw exception when key longer than 64 characters disqus/gargoyle#103 throw exception when key longer than 64 characters
❌ Thought about it in throw exception when key longer than 64 characters #28, but ultimately consider not worth merging - MySQL users should just activate strict mode
Metadata
Metadata
Assignees
Labels
No labels