add Microsoft.VisualStudio.Threading.Analyzers

adamralph · adamralph · commit 121ee76a7a7a · 2026-01-11T12:41:56.000+01:00
diff --git a/Directory.Build.props b/Directory.Build.props
@@ -20,4 +20,8 @@
     <Compile Include="$(MSBuildThisFileDirectory)/Global.cs" Link="Global.cs" />
   </ItemGroup>
 
+  <ItemGroup>
+    <PackageReference Include="Microsoft.VisualStudio.Threading.Analyzers" Version="17.14.15" PrivateAssets="All" />
+  </ItemGroup>
+
 </Project>
diff --git a/SimpleExec/Command.cs b/SimpleExec/Command.cs
@@ -429,8 +429,10 @@ private static async Task RunAsync(
         await Task.WhenAll(runProcess, readOutput, readError).ConfigureAwait(false);
 
 #pragma warning disable CA1849 // Call async methods when in an async method
+#pragma warning disable VSTHRD103 // Result synchronously blocks. Use await instead.
         var output = readOutput.Result;
         var error = readError.Result;
+#pragma warning restore VSTHRD103
 #pragma warning restore CA1849
 
         return (handleExitCode?.Invoke(process.ExitCode) ?? false) || process.ExitCode == 0
diff --git a/SimpleExec/packages.lock.json b/SimpleExec/packages.lock.json
@@ -20,6 +20,12 @@
         "resolved": "4.1.5",
         "contentHash": "i5z+cNu/cOcdO0AgFB8aXk8w6In2H+haaDfSgd9ImvQIK+rSHavHZIogVoAZLL8jLwYx4bAcs5b7EyuMMG4mQQ=="
       },
+      "Microsoft.VisualStudio.Threading.Analyzers": {
+        "type": "Direct",
+        "requested": "[17.14.15, )",
+        "resolved": "17.14.15",
+        "contentHash": "mXQPJsbuUD2ydq4/ffd8h8tSOFCXec+2xJOVNCvXjuMOq/+5EKHq3D2m2MC2+nUaXeFMSt66VS/J4HdKBixgcw=="
+      },
       "MinVer": {
         "type": "Direct",
         "requested": "[8.0.0-alpha.1, )",
@@ -46,6 +52,12 @@
         "resolved": "4.1.5",
         "contentHash": "i5z+cNu/cOcdO0AgFB8aXk8w6In2H+haaDfSgd9ImvQIK+rSHavHZIogVoAZLL8jLwYx4bAcs5b7EyuMMG4mQQ=="
       },
+      "Microsoft.VisualStudio.Threading.Analyzers": {
+        "type": "Direct",
+        "requested": "[17.14.15, )",
+        "resolved": "17.14.15",
+        "contentHash": "mXQPJsbuUD2ydq4/ffd8h8tSOFCXec+2xJOVNCvXjuMOq/+5EKHq3D2m2MC2+nUaXeFMSt66VS/J4HdKBixgcw=="
+      },
       "MinVer": {
         "type": "Direct",
         "requested": "[8.0.0-alpha.1, )",
@@ -72,6 +84,12 @@
         "resolved": "4.1.5",
         "contentHash": "i5z+cNu/cOcdO0AgFB8aXk8w6In2H+haaDfSgd9ImvQIK+rSHavHZIogVoAZLL8jLwYx4bAcs5b7EyuMMG4mQQ=="
       },
+      "Microsoft.VisualStudio.Threading.Analyzers": {
+        "type": "Direct",
+        "requested": "[17.14.15, )",
+        "resolved": "17.14.15",
+        "contentHash": "mXQPJsbuUD2ydq4/ffd8h8tSOFCXec+2xJOVNCvXjuMOq/+5EKHq3D2m2MC2+nUaXeFMSt66VS/J4HdKBixgcw=="
+      },
       "MinVer": {
         "type": "Direct",
         "requested": "[8.0.0-alpha.1, )",
diff --git a/SimpleExecTester/packages.lock.json b/SimpleExecTester/packages.lock.json
@@ -1,8 +1,29 @@
 {
   "version": 1,
   "dependencies": {
-    "net10.0": {},
-    "net8.0": {},
-    "net9.0": {}
+    "net10.0": {
+      "Microsoft.VisualStudio.Threading.Analyzers": {
+        "type": "Direct",
+        "requested": "[17.14.15, )",
+        "resolved": "17.14.15",
+        "contentHash": "mXQPJsbuUD2ydq4/ffd8h8tSOFCXec+2xJOVNCvXjuMOq/+5EKHq3D2m2MC2+nUaXeFMSt66VS/J4HdKBixgcw=="
+      }
+    },
+    "net8.0": {
+      "Microsoft.VisualStudio.Threading.Analyzers": {
+        "type": "Direct",
+        "requested": "[17.14.15, )",
+        "resolved": "17.14.15",
+        "contentHash": "mXQPJsbuUD2ydq4/ffd8h8tSOFCXec+2xJOVNCvXjuMOq/+5EKHq3D2m2MC2+nUaXeFMSt66VS/J4HdKBixgcw=="
+      }
+    },
+    "net9.0": {
+      "Microsoft.VisualStudio.Threading.Analyzers": {
+        "type": "Direct",
+        "requested": "[17.14.15, )",
+        "resolved": "17.14.15",
+        "contentHash": "mXQPJsbuUD2ydq4/ffd8h8tSOFCXec+2xJOVNCvXjuMOq/+5EKHq3D2m2MC2+nUaXeFMSt66VS/J4HdKBixgcw=="
+      }
+    }
   }
 }
diff --git a/SimpleExecTests/.editorconfig b/SimpleExecTests/.editorconfig
@@ -2,3 +2,6 @@
 
 # CA2007: Consider calling ConfigureAwait on the awaited task
 dotnet_diagnostic.CA2007.severity = none
+
+# VSTHRD111: Add .ConfigureAwait(bool) to your await expression
+dotnet_diagnostic.VSTHRD111.severity = none
diff --git a/SimpleExecTests/CancellingCommands.cs b/SimpleExecTests/CancellingCommands.cs
@@ -75,7 +75,10 @@ public static async Task RunningACommandAsyncWithCreateNoWindow(bool createNoWin
         await cts.CancelAsync();
 
         // assert
+#pragma warning disable VSTHRD003 // Avoid awaiting or returning a Task representing work that was not started within your context as that can lead to deadlocks.
         var exception = await Record.ExceptionAsync(() => command);
+#pragma warning restore VSTHRD003
+
         Assert.Equal(ct, Assert.IsType<TaskCanceledException>(exception).CancellationToken);
     }
 }
diff --git a/SimpleExecTests/packages.lock.json b/SimpleExecTests/packages.lock.json
@@ -14,6 +14,12 @@
         "resolved": "2.0.2",
         "contentHash": "43NCOTEENtdc9fmlzX9KHQR14AZEYek5r4jOJlWPhTyV1+aYAQYl4x773nYXU5TKxV6+rMuniJ7wcj9C9qrP1A=="
       },
+      "Microsoft.VisualStudio.Threading.Analyzers": {
+        "type": "Direct",
+        "requested": "[17.14.15, )",
+        "resolved": "17.14.15",
+        "contentHash": "mXQPJsbuUD2ydq4/ffd8h8tSOFCXec+2xJOVNCvXjuMOq/+5EKHq3D2m2MC2+nUaXeFMSt66VS/J4HdKBixgcw=="
+      },
       "PublicApiGenerator": {
         "type": "Direct",
         "requested": "[11.5.4, )",
@@ -209,6 +215,12 @@
         "resolved": "2.0.2",
         "contentHash": "43NCOTEENtdc9fmlzX9KHQR14AZEYek5r4jOJlWPhTyV1+aYAQYl4x773nYXU5TKxV6+rMuniJ7wcj9C9qrP1A=="
       },
+      "Microsoft.VisualStudio.Threading.Analyzers": {
+        "type": "Direct",
+        "requested": "[17.14.15, )",
+        "resolved": "17.14.15",
+        "contentHash": "mXQPJsbuUD2ydq4/ffd8h8tSOFCXec+2xJOVNCvXjuMOq/+5EKHq3D2m2MC2+nUaXeFMSt66VS/J4HdKBixgcw=="
+      },
       "PublicApiGenerator": {
         "type": "Direct",
         "requested": "[11.5.4, )",
@@ -404,6 +416,12 @@
         "resolved": "2.0.2",
         "contentHash": "43NCOTEENtdc9fmlzX9KHQR14AZEYek5r4jOJlWPhTyV1+aYAQYl4x773nYXU5TKxV6+rMuniJ7wcj9C9qrP1A=="
       },
+      "Microsoft.VisualStudio.Threading.Analyzers": {
+        "type": "Direct",
+        "requested": "[17.14.15, )",
+        "resolved": "17.14.15",
+        "contentHash": "mXQPJsbuUD2ydq4/ffd8h8tSOFCXec+2xJOVNCvXjuMOq/+5EKHq3D2m2MC2+nUaXeFMSt66VS/J4HdKBixgcw=="
+      },
       "PublicApiGenerator": {
         "type": "Direct",
         "requested": "[11.5.4, )",
diff --git a/targets/.editorconfig b/targets/.editorconfig
@@ -2,3 +2,6 @@
 
 # CA2007: Consider calling ConfigureAwait on the awaited task
 dotnet_diagnostic.CA2007.severity = none
+
+# VSTHRD111: Add .ConfigureAwait(bool) to your await expression
+dotnet_diagnostic.VSTHRD111.severity = none
diff --git a/targets/packages.lock.json b/targets/packages.lock.json
@@ -7,6 +7,12 @@
         "requested": "[6.1.0, )",
         "resolved": "6.1.0",
         "contentHash": "fltnAJDe0BEX5eymXGUq+il2rSUA0pHqUonNDRH2TrvRu8SkU17mYG0IVpdmG2ibtfhdjNrv4CuTCxHOwcozCA=="
+      },
+      "Microsoft.VisualStudio.Threading.Analyzers": {
+        "type": "Direct",
+        "requested": "[17.14.15, )",
+        "resolved": "17.14.15",
+        "contentHash": "mXQPJsbuUD2ydq4/ffd8h8tSOFCXec+2xJOVNCvXjuMOq/+5EKHq3D2m2MC2+nUaXeFMSt66VS/J4HdKBixgcw=="
       }
     }
   }

Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,10 @@ public static async Task RunningACommandAsyncWithCreateNoWindow(bool createNoWin`
`75`	`75`	`await cts.CancelAsync();`
`76`	`76`
`77`	`77`	`// assert`
	`78`	`+#pragma warning disable VSTHRD003 // Avoid awaiting or returning a Task representing work that was not started within your context as that can lead to deadlocks.`
`78`	`79`	`var exception = await Record.ExceptionAsync(() => command);`
	`80`	`+#pragma warning restore VSTHRD003`
	`81`	`+`
`79`	`82`	`Assert.Equal(ct, Assert.IsType<TaskCanceledException>(exception).CancellationToken);`
`80`	`83`	`}`
`81`	`84`	`}`
Original file line number	Diff line number	Diff line change
`@@ -7,6 +7,12 @@`
`7`	`7`	`"requested": "[6.1.0, )",`
`8`	`8`	`"resolved": "6.1.0",`
`9`	`9`	`"contentHash": "fltnAJDe0BEX5eymXGUq+il2rSUA0pHqUonNDRH2TrvRu8SkU17mYG0IVpdmG2ibtfhdjNrv4CuTCxHOwcozCA=="`
	`10`	`+ },`
	`11`	`+ "Microsoft.VisualStudio.Threading.Analyzers": {`
	`12`	`+ "type": "Direct",`
	`13`	`+ "requested": "[17.14.15, )",`
	`14`	`+ "resolved": "17.14.15",`
	`15`	`+ "contentHash": "mXQPJsbuUD2ydq4/ffd8h8tSOFCXec+2xJOVNCvXjuMOq/+5EKHq3D2m2MC2+nUaXeFMSt66VS/J4HdKBixgcw=="`
`10`	`16`	`}`
`11`	`17`	`}`
`12`	`18`	`}`