docs: consolidate implementation into 2 phases (Thrift gaps first, SEA second)

Co-authored-by: Isaac

Author: Jade Wang

docs/designs/fix-telemetry-gaps-design.md

@@ -631,37 +631,44 @@ The following proto fields are **not applicable** to the C# ADBC driver and will
 
 ## Implementation Priority
 
-### Phase 1: E2E Test Infrastructure (Test-First)
+### Phase 1: Thrift Telemetry Gaps (Missing Fields, ChunkDetails, Behavioral Changes)
+
+Fix all gaps in the existing Thrift telemetry pipeline first, since the infrastructure is already in place.
+
+**E2E Tests (test-first):**
 1. Build E2E test infrastructure using `CapturingTelemetryExporter` to assert proto field values
-2. Write E2E tests for all currently populated proto fields (Thrift) - these establish the baseline
-3. Write failing E2E tests for missing fields (auth_type, WorkspaceId, runtime_vendor, etc.) - these drive Phase 2-5
-4. Write failing E2E tests for SEA telemetry (expect telemetry events from SEA connections) - these drive Phase 2
-5. Write failing E2E tests for ChunkDetails fields - these drive Phase 4
-
-### Phase 2: SEA Telemetry (Highest Priority - Zero Coverage Today)
-6. Extract `TelemetryHelper` from `DatabricksConnection` for shared use
-7. Wire `InitializeTelemetry()` into `StatementExecutionConnection` with `mode=SEA`
-8. Add `EmitTelemetry()` to `StatementExecutionStatement`
-9. Wire telemetry dispose/flush into `StatementExecutionConnection.Dispose()`
-10. Verify SEA E2E tests from Phase 1 now pass
-
-### Phase 3: Missing Fields (Low Risk)
-11. Populate `runtime_vendor` and `client_app_name` in DriverSystemConfiguration
-12. Populate `auth_type` on root log
-13. Populate additional DriverConnectionParameters (enable_arrow, rows_fetched_per_block, etc.)
-14. Set `WorkspaceId` in TelemetrySessionContext
-15. Verify missing-field E2E tests from Phase 1 now pass
-
-### Phase 4: ChunkDetails Wiring (Medium Risk - Crosses Component Boundaries)
-16. Add `ChunkMetrics` aggregation to `CloudFetchDownloader`
-17. Expose metrics via `CloudFetchReader.GetChunkMetrics()`
-18. Call `SetChunkDetails()` in `DatabricksStatement.EmitTelemetry()` and `StatementExecutionStatement.EmitTelemetry()`
-19. Verify ChunkDetails E2E tests from Phase 1 now pass
-
-### Phase 5: Other Behavioral Changes (Medium Risk)
-20. Track `retry_count` on SqlExecutionEvent
-21. Mark internal calls with `is_internal_call = true`
-22. Add metadata operation telemetry (GetObjects, GetTableTypes)
+2. Write E2E tests for all currently populated proto fields (Thrift) - establish the baseline
+3. Write failing E2E tests for missing fields (auth_type, WorkspaceId, runtime_vendor, client_app_name, etc.)
+4. Write failing E2E tests for ChunkDetails fields
+5. Write failing E2E tests for metadata operations and internal call tracking
+
+**Implementation:**
+6. Populate `runtime_vendor` and `client_app_name` in DriverSystemConfiguration
+7. Populate `auth_type` on root log
+8. Populate additional DriverConnectionParameters (enable_arrow, rows_fetched_per_block, etc.)
+9. Set `WorkspaceId` in TelemetrySessionContext
+10. Add `ChunkMetrics` aggregation to `CloudFetchDownloader`
+11. Expose metrics via `CloudFetchReader.GetChunkMetrics()`
+12. Call `SetChunkDetails()` in `DatabricksStatement.EmitTelemetry()`
+13. Track `retry_count` on SqlExecutionEvent
+14. Mark internal calls with `is_internal_call = true`
+15. Add metadata operation telemetry (GetObjects, GetTableTypes)
+16. Verify all Phase 1 E2E tests pass
+
+### Phase 2: SEA Telemetry (Wire Telemetry into StatementExecutionConnection)
+
+Once Thrift telemetry is complete, extend coverage to the SEA protocol using the shared `TelemetryHelper`.
+
+**E2E Tests (test-first):**
+17. Write failing E2E tests for SEA telemetry (expect telemetry events from SEA connections)
+
+**Implementation:**
+18. Extract `TelemetryHelper` from `DatabricksConnection` for shared use (already done - verify coverage)
+19. Wire `InitializeTelemetry()` into `StatementExecutionConnection` with `mode=SEA`
+20. Add `EmitTelemetry()` to `StatementExecutionStatement`
+21. Wire telemetry dispose/flush into `StatementExecutionConnection.Dispose()`
+22. Wire `SetChunkDetails()` in `StatementExecutionStatement.EmitTelemetry()` for SEA CloudFetch
+23. Verify all Phase 2 SEA E2E tests pass
 
 ---