Commit dcdcf49
committed
fix(csharp): always send CloseOperation from DatabricksCompositeReader.Dispose
Previously, DatabricksCompositeReader.Dispose only called CloseOperation
when _activeReader was null. When a CloudFetchReader was active, it
delegated Dispose to the reader, but CloudFetchReader is protocol-agnostic
and never sends CloseOperation. This orphaned every CloudFetch server
operation for ~1 hour until SQL Gateway fired CommandInactivityTimeout,
producing thriftOperationCloseReason=CommandInactivityTimeout in usage logs.
Move CloseOperation ownership entirely to DatabricksCompositeReader.Dispose,
which holds both _statement (Thrift client) and _response (operation handle).
HiveServer2Reader.CloseOperationAsync is already a no-op when DirectResults
already closed the operation server-side, so all three result paths are safe:
- Inline + DirectResults enabled: CloseOperation is a no-op (already closed)
- Inline + DirectResults disabled: CloseOperation sent explicitly
- CloudFetch: CloseOperation sent explicitly (was previously missing)
Remove CloseOperation from DatabricksReader.Dispose to avoid duplicate calls;
DatabricksReader is only ever constructed from DatabricksCompositeReader.1 parent d4083ce commit dcdcf49
File tree
2 files changed
+7
-12
lines changed- csharp/src/Reader
2 files changed
+7
-12
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
237 | 237 | | |
238 | 238 | | |
239 | 239 | | |
240 | | - | |
241 | | - | |
242 | | - | |
243 | | - | |
244 | | - | |
245 | | - | |
246 | | - | |
| 240 | + | |
| 241 | + | |
| 242 | + | |
| 243 | + | |
| 244 | + | |
| 245 | + | |
| 246 | + | |
247 | 247 | | |
248 | 248 | | |
249 | 249 | | |
250 | 250 | | |
251 | | - | |
252 | 251 | | |
253 | 252 | | |
254 | 253 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
241 | 241 | | |
242 | 242 | | |
243 | 243 | | |
244 | | - | |
245 | | - | |
246 | | - | |
247 | | - | |
248 | 244 | | |
249 | 245 | | |
250 | 246 | | |
| |||
0 commit comments