feat: enable bulk ingest into temp table#74
Merged
lidavidm merged 2 commits intoadbc-drivers:mainfrom Mar 6, 2026
Merged
Conversation
Contributor
|
I think there is at least one other system with the same problem. I'll think about what to do there. |
Contributor
|
I'll rebase this and add some fixes to enable testing this in the validation suite! |
lidavidm
force-pushed
the
ingest-into-temp-table
branch
from
b46d4ae to
c75a230
Compare
lidavidm
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
adds support for bulk ingest into temporary tables. Unfortunately, I was unable to enable temp tables validation test as the test creates a normal table and temp table with identical names. mysql can't really easily distinguish between the two as the temp table name shadows over the name of the normal table w/o database qualifier.
Not sure what the correct course of action is here. maybe introduce another less strict test that just checks that the table is not accessible from another connection?