Resource Ordering Issue in instool.pp

[ljohnston]

Should the 'before' in the following from instool.pp...

  file{$instdir:
    ensure  => directory,
    recurse => true,
    source  => $tmpdir,
    before  => Exec['download_and_untar'],
  }

...be a 'require'...

  file{$instdir:
    ensure  => directory,
    recurse => true,
    source  => $tmpdir,
    require => Exec['download_and_untar'],
  }

This file resource is trying to recursively copy its contents from $tmpdir, but $tmpdir has no contents until Exec['download_and_untar'] is applied.

The module would not work for me until I made the above modification.