Fixing memory leak

jekuer · Copilot · jekuer · commit a3a3bc8be218 · 2026-04-30T20:58:16.000+02:00
Co-authored-by: Copilot &lt;copilot@github.com&gt;
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -2,6 +2,7 @@
 
 ## Version 2
 
+- v2.14 : Dropping atcb_decorate_data_recurrence export; various bug fixes
 - v2.13 : Hebrew language
 - v2.12 : ⚠️ Breaking: Date buttons now show the next possible date in multi-date and recurrence cases. Recurrence UNTIL support. Mitigating edge cases where ics files with unsupported time zones loaded into Google calendar. Always block background scroll on modals open
 - v2.11 : ⚠️ Breaking: When setting the dates objects and respective attributes on the root level, root values always override the dates object (except for name in the multi-date case)
diff --git a/assets/css/atcb-3d.css b/assets/css/atcb-3d.css
@@ -5,7 +5,7 @@
  *
  * Style: 3D
  *
- * Version: 2.13.10
+ * Version: 2.14.0
  * Creator: Jens Kuerschner (https://jekuer.com)
  * Project: https://github.com/add2cal/add-to-calendar-button
  * License: Elastic License 2.0 (ELv2) (https://github.com/add2cal/add-to-calendar-button/blob/main/LICENSE.txt)
diff --git a/assets/css/atcb-date.css b/assets/css/atcb-date.css
@@ -5,7 +5,7 @@
  *
  * Style: Date
  *
- * Version: 2.13.10
+ * Version: 2.14.0
  * Creator: Jens Kuerschner (https://jekuer.com)
  * Project: https://github.com/add2cal/add-to-calendar-button
  * License: Elastic License 2.0 (ELv2) (https://github.com/add2cal/add-to-calendar-button/blob/main/LICENSE.txt)
diff --git a/assets/css/atcb-flat.css b/assets/css/atcb-flat.css
@@ -5,7 +5,7 @@
  *
  * Style: Flat
  *
- * Version: 2.13.10
+ * Version: 2.14.0
  * Creator: Jens Kuerschner (https://jekuer.com)
  * Project: https://github.com/add2cal/add-to-calendar-button
  * License: Elastic License 2.0 (ELv2) (https://github.com/add2cal/add-to-calendar-button/blob/main/LICENSE.txt)
diff --git a/assets/css/atcb-neumorphism.css b/assets/css/atcb-neumorphism.css
@@ -5,7 +5,7 @@
  *
  * Style: Neumorphism
  *
- * Version: 2.13.10
+ * Version: 2.14.0
  * Creator: Jens Kuerschner (https://jekuer.com)
  * Project: https://github.com/add2cal/add-to-calendar-button
  * License: Elastic License 2.0 (ELv2) (https://github.com/add2cal/add-to-calendar-button/blob/main/LICENSE.txt)
diff --git a/assets/css/atcb-round.css b/assets/css/atcb-round.css
@@ -5,7 +5,7 @@
  *
  * Style: Round
  *
- * Version: 2.13.10
+ * Version: 2.14.0
  * Creator: Jens Kuerschner (https://jekuer.com)
  * Project: https://github.com/add2cal/add-to-calendar-button
  * License: Elastic License 2.0 (ELv2) (https://github.com/add2cal/add-to-calendar-button/blob/main/LICENSE.txt)
diff --git a/assets/css/atcb-simple.css b/assets/css/atcb-simple.css
@@ -5,7 +5,7 @@
  *
  * Style: Simple
  *
- * Version: 2.13.10
+ * Version: 2.14.0
  * Creator: Jens Kuerschner (https://jekuer.com)
  * Project: https://github.com/add2cal/add-to-calendar-button
  * License: Elastic License 2.0 (ELv2) (https://github.com/add2cal/add-to-calendar-button/blob/main/LICENSE.txt)
diff --git a/assets/css/atcb-text.css b/assets/css/atcb-text.css
@@ -5,7 +5,7 @@
  *
  * Style: Text
  *
- * Version: 2.13.10
+ * Version: 2.14.0
  * Creator: Jens Kuerschner (https://jekuer.com)
  * Project: https://github.com/add2cal/add-to-calendar-button
  * License: Elastic License 2.0 (ELv2) (https://github.com/add2cal/add-to-calendar-button/blob/main/LICENSE.txt)
diff --git a/assets/css/atcb.css b/assets/css/atcb.css
@@ -5,7 +5,7 @@
  *
  * Style: Default
  *
- * Version: 2.13.10
+ * Version: 2.14.0
  * Creator: Jens Kuerschner (https://jekuer.com)
  * Project: https://github.com/add2cal/add-to-calendar-button
  * License: Elastic License 2.0 (ELv2) (https://github.com/add2cal/add-to-calendar-button/blob/main/LICENSE.txt)
diff --git a/demo/components/footer.vue b/demo/components/footer.vue
@@ -70,7 +70,7 @@ function topFunction() {
             </span>
             <div class="mt-6 text-xs sm:mt-5 md:mt-3">
               <span class="font-semibold text-zinc-500 dark:text-zinc-400"> &copy; {{new Date().getFullYear()}} Calendarverse GmbH</span>
-              <span class="lowercase text-zinc-400 dark:text-zinc-500">, Current Version: 2.13.10 </span>
+              <span class="lowercase text-zinc-400 dark:text-zinc-500">, Current Version: 2.14.0 </span>
             </div>
           </div>
           <div class="hidden self-center sm:block">
diff --git a/demo/public/atcb.css b/demo/public/atcb.css
@@ -5,7 +5,7 @@
  *
  * Style: Default
  *
- * Version: 2.13.10
+ * Version: 2.14.0
  * Creator: Jens Kuerschner (https://jekuer.com)
  * Project: https://github.com/add2cal/add-to-calendar-button
  * License: Elastic License 2.0 (ELv2) (https://github.com/add2cal/add-to-calendar-button/blob/main/LICENSE.txt)
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "add-to-calendar-button",
-  "version": "2.13.10",
+  "version": "2.14.0",
   "engines": {
     "node": ">=18.17.0",
     "npm": ">=9.6.7"
diff --git a/src/atcb-globals.js b/src/atcb-globals.js
@@ -5,15 +5,15 @@
  *  Add to Calendar Button
  *  ++++++++++++++++++++++
  *
- *  Version: 2.13.10
+ *  Version: 2.14.0
  *  Creator: Jens Kuerschner (https://jekuer.com)
  *  Publisher: Calendarverse GmbH (https://add-to-calendar-pro.com)
  *  Project: https://github.com/add2cal/add-to-calendar-button
  *  License: Elastic License 2.0 (ELv2) (https://github.com/add2cal/add-to-calendar-button/blob/main/LICENSE.txt)
  *  Note:    DO NOT REMOVE THE COPYRIGHT NOTICE ABOVE!
  *
  */
-const atcbVersion = '2.13.10';
+const atcbVersion = '2.14.0';
 
 // DEFINING CSS
 const atcbCssTemplate = {};
diff --git a/src/atcb-init.js b/src/atcb-init.js
@@ -11,7 +11,7 @@ import { atcb_generate_rsvp_form, atcb_generate_rsvp_button } from './atcb-gener
 
 let atcbInitialGlobalInit = false;
 let atcbBtnCount = 0;
-const lightModeMutationObserver = [];
+const lightModeMutationObserver = new Map();
 
 const template = `<div class="atcb-initialized atcb-hidden"></div>`;
 
@@ -818,15 +818,21 @@ function atcb_set_global_event_listener(host, data) {
   }
   // temporary listener to any class change at the body or html for the light mode Safari/Firefox hack
   if (data.lightMode == 'bodyScheme') {
-    lightModeMutationObserver[data.identifier] = new MutationObserver(function (mutationsList) {
+    // disconnect any previous observer for this identifier to avoid leaking observers
+    const existingObserver = lightModeMutationObserver.get(data.identifier);
+    if (existingObserver) {
+      existingObserver.disconnect();
+    }
+    const observer = new MutationObserver(function (mutationsList) {
       mutationsList.forEach((mutation) => {
         if (mutation.attributeName === 'class') {
           atcb_set_light_mode(host, data);
         }
       });
     });
-    lightModeMutationObserver[data.identifier].observe(document.documentElement, { attributes: true });
-    lightModeMutationObserver[data.identifier].observe(document.body, { attributes: true });
+    observer.observe(document.documentElement, { attributes: true });
+    observer.observe(document.body, { attributes: true });
+    lightModeMutationObserver.set(data.identifier, observer);
   }
   if (!atcbInitialGlobalInit) {
     // global listener for ESC key to close dropdown
@@ -929,8 +935,10 @@ function atcb_global_listener_resize() {
 }
 
 function atcb_unset_global_event_listener(identifier) {
-  if (typeof lightModeMutationObserver[`${identifier}`] !== 'undefined') {
-    lightModeMutationObserver[`${identifier}`].disconnect();
+  const observer = lightModeMutationObserver.get(identifier);
+  if (observer) {
+    observer.disconnect();
+    lightModeMutationObserver.delete(identifier);
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,7 @@`
`5`	`5`	`*`
`6`	`6`	`* Style: 3D`
`7`	`7`	`*`
`8`		`- * Version: 2.13.10`
	`8`	`+ * Version: 2.14.0`
`9`	`9`	`* Creator: Jens Kuerschner (https://jekuer.com)`
`10`	`10`	`* Project: https://github.com/add2cal/add-to-calendar-button`
`11`	`11`	`* License: Elastic License 2.0 (ELv2) (https://github.com/add2cal/add-to-calendar-button/blob/main/LICENSE.txt)`
Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,7 @@`
`5`	`5`	`*`
`6`	`6`	`* Style: Date`
`7`	`7`	`*`
`8`		`- * Version: 2.13.10`
	`8`	`+ * Version: 2.14.0`
`9`	`9`	`* Creator: Jens Kuerschner (https://jekuer.com)`
`10`	`10`	`* Project: https://github.com/add2cal/add-to-calendar-button`
`11`	`11`	`* License: Elastic License 2.0 (ELv2) (https://github.com/add2cal/add-to-calendar-button/blob/main/LICENSE.txt)`
Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,7 @@`
`5`	`5`	`*`
`6`	`6`	`* Style: Flat`
`7`	`7`	`*`
`8`		`- * Version: 2.13.10`
	`8`	`+ * Version: 2.14.0`
`9`	`9`	`* Creator: Jens Kuerschner (https://jekuer.com)`
`10`	`10`	`* Project: https://github.com/add2cal/add-to-calendar-button`
`11`	`11`	`* License: Elastic License 2.0 (ELv2) (https://github.com/add2cal/add-to-calendar-button/blob/main/LICENSE.txt)`
Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,7 @@`
`5`	`5`	`*`
`6`	`6`	`* Style: Neumorphism`
`7`	`7`	`*`
`8`		`- * Version: 2.13.10`
	`8`	`+ * Version: 2.14.0`
`9`	`9`	`* Creator: Jens Kuerschner (https://jekuer.com)`
`10`	`10`	`* Project: https://github.com/add2cal/add-to-calendar-button`
`11`	`11`	`* License: Elastic License 2.0 (ELv2) (https://github.com/add2cal/add-to-calendar-button/blob/main/LICENSE.txt)`
Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,7 @@`
`5`	`5`	`*`
`6`	`6`	`* Style: Round`
`7`	`7`	`*`
`8`		`- * Version: 2.13.10`
	`8`	`+ * Version: 2.14.0`
`9`	`9`	`* Creator: Jens Kuerschner (https://jekuer.com)`
`10`	`10`	`* Project: https://github.com/add2cal/add-to-calendar-button`
`11`	`11`	`* License: Elastic License 2.0 (ELv2) (https://github.com/add2cal/add-to-calendar-button/blob/main/LICENSE.txt)`
Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,7 @@`
`5`	`5`	`*`
`6`	`6`	`* Style: Simple`
`7`	`7`	`*`
`8`		`- * Version: 2.13.10`
	`8`	`+ * Version: 2.14.0`
`9`	`9`	`* Creator: Jens Kuerschner (https://jekuer.com)`
`10`	`10`	`* Project: https://github.com/add2cal/add-to-calendar-button`
`11`	`11`	`* License: Elastic License 2.0 (ELv2) (https://github.com/add2cal/add-to-calendar-button/blob/main/LICENSE.txt)`
Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,7 @@`
`5`	`5`	`*`
`6`	`6`	`* Style: Text`
`7`	`7`	`*`
`8`		`- * Version: 2.13.10`
	`8`	`+ * Version: 2.14.0`
`9`	`9`	`* Creator: Jens Kuerschner (https://jekuer.com)`
`10`	`10`	`* Project: https://github.com/add2cal/add-to-calendar-button`
`11`	`11`	`* License: Elastic License 2.0 (ELv2) (https://github.com/add2cal/add-to-calendar-button/blob/main/LICENSE.txt)`
Original file line number	Diff line number	Diff line change
`@@ -5,7 +5,7 @@`
`5`	`5`	`*`
`6`	`6`	`* Style: Default`
`7`	`7`	`*`
`8`		`- * Version: 2.13.10`
	`8`	`+ * Version: 2.14.0`
`9`	`9`	`* Creator: Jens Kuerschner (https://jekuer.com)`
`10`	`10`	`* Project: https://github.com/add2cal/add-to-calendar-button`
`11`	`11`	`* License: Elastic License 2.0 (ELv2) (https://github.com/add2cal/add-to-calendar-button/blob/main/LICENSE.txt)`