Skip to content

Fix: Windows Security Vulnerability and Test Failures #1430

@Tahir-yamin

Description

@Tahir-yamin

Description

This issue tracks critical fixes for Windows support and test reliability:

  1. Security Vulnerability: tools/src/aden_tools/.../security.py allows sandbox escape on Windows because lstrip(os.sep) fails to remove the leading slash from absolute paths like /etc/passwd when os.sep is \.
  2. Test Failure: test_credentials.py fails on fresh installs because it expects optional API keys (Anthropic) to be required.
  3. Windows Compatibility: test_file_system_toolkits.py fails on Windows because it attempts to run Unix commands like ls and tr.

Proposed Solution

  • Patch security.py to strip both \ and /.
  • Update test_credentials.py to assert correct optional behavior.
  • Mock subprocess.run in tests to be OS-agnostic.

Assignee

@Tahir-yamin

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions