Skip to content

Commit 868061d

Browse files
Alexander Kjällalexanderkjall
Alexander Kjäll
authored andcommitted
reviewer feedback, rename IsHostnameNoDnsResolution to IsHostnameNoDNSResolution
1 parent b0bccbe commit 868061d

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

types.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -215,8 +215,8 @@ func IsHostname(target string) bool {
215215
return len(r) > 0
216216
}
217217

218-
// IsHostnameNoDnsResolution returns true if the target is not an IP.
219-
func IsHostnameNoDnsResolution(target string) bool {
218+
// IsHostnameNoDNSResolution returns true if the target is not an IP.
219+
func IsHostnameNoDNSResolution(target string) bool {
220220
// If the target is an IP can not be a hostname.
221221
if IsIP(target) {
222222
return false

types_test.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -628,7 +628,7 @@ func TestIsHostname(t *testing.T) {
628628
}
629629
}
630630

631-
func TestIsHostnameNoDnsResolution(t *testing.T) {
631+
func TestIsHostnameNoDNSResolution(t *testing.T) {
632632
tests := []struct {
633633
name string
634634
target string
@@ -659,7 +659,7 @@ func TestIsHostnameNoDnsResolution(t *testing.T) {
659659
for _, tt := range tests {
660660
tt := tt
661661
t.Run(tt.name, func(t *testing.T) {
662-
got := IsHostnameNoDnsResolution(tt.target)
662+
got := IsHostnameNoDNSResolution(tt.target)
663663
if got != tt.want {
664664
t.Errorf("got %v, want %v", got, tt.want)
665665
}

0 commit comments

Comments
 (0)