Phase 21.5: Stabilization - fix critical bugs from codebase audit #13
ci.yml
on: push
Lint
22s
Unit Tests
19s
Integration Tests
22s
Build
18s
E2E Tests
1m 17s
Annotations
10 errors and 4 warnings
|
live-session.test.ts > Router: blocks PATCH (rename) on published sessions with 403:
app/test/integration/live-session.test.ts#L714
AssertionError: expected 404 to be 403 // Object.is equality
- Expected
+ Received
- 403
+ 404
❯ live-session.test.ts:714:32
|
|
live-session.test.ts > Router: blocks PUT updates on published sessions with 403:
app/test/integration/live-session.test.ts#L687
AssertionError: expected 404 to be 403 // Object.is equality
- Expected
+ Received
- 403
+ 404
❯ live-session.test.ts:687:33
|
|
live-session.test.ts > Router: publish is idempotent (calling twice returns success):
app/test/integration/live-session.test.ts#L656
AssertionError: expected 404 to be 200 // Object.is equality
- Expected
+ Received
- 200
+ 404
❯ live-session.test.ts:656:27
|
|
live-session.test.ts > Router: publishes a session via POST /api/sessions/:id/publish:
app/test/integration/live-session.test.ts#L631
AssertionError: expected 404 to be 200 // Object.is equality
- Expected
+ Received
- 200
+ 404
❯ live-session.test.ts:631:34
|
|
live-session.test.ts > Router: rejects invalid step count (e.g., 13):
app/test/integration/live-session.test.ts#L606
AssertionError: expected 429 to be 400 // Object.is equality
- Expected
+ Received
- 400
+ 429
❯ live-session.test.ts:606:27
|
|
live-session.test.ts > Router: accepts all valid step count options (4, 8, 12, 16, 24, 32, 64):
app/test/integration/live-session.test.ts#L572
AssertionError: expected 429 to be 201 // Object.is equality
- Expected
+ Received
- 201
+ 429
❯ live-session.test.ts:572:29
|
|
live-session.test.ts > Router: persists parameter locks with pitch and volume:
app/test/integration/live-session.test.ts#L522
AssertionError: expected 429 to be 201 // Object.is equality
- Expected
+ Received
- 201
+ 429
❯ live-session.test.ts:522:27
|
|
live-session.test.ts > Router: rejects transpose outside ±24 range:
app/test/integration/live-session.test.ts#L477
AssertionError: expected 429 to be 400 // Object.is equality
- Expected
+ Received
- 400
+ 429
❯ live-session.test.ts:477:27
|
|
live-session.test.ts > Router: accepts +24 semitone transpose (high melodic):
app/test/integration/live-session.test.ts#L444
AssertionError: expected 429 to be 201 // Object.is equality
- Expected
+ Received
- 201
+ 429
❯ live-session.test.ts:444:27
|
|
live-session.test.ts > Router: accepts -24 semitone transpose (deep sub-bass):
app/test/integration/live-session.test.ts#L410
AssertionError: expected 429 to be 201 // Object.is equality
- Expected
+ Received
- 201
+ 429
❯ live-session.test.ts:410:27
|
|
Lint:
app/src/hooks/useSession.ts#L216
React Hook useEffect has a missing dependency: 'state'. Either include it or remove the dependency array
|
|
Lint:
app/src/hooks/useSession.ts#L168
React Hook useEffect has missing dependencies: 'isDebugMode', 'loadState', 'logError', 'logState', 'resetState', and 'setSessionInfo'. Either include them or remove the dependency array. If 'resetState' changes too often, find the parent component that defines it and wrap that definition in useCallback
|
|
Lint:
app/src/hooks/useQRMode.ts#L65
React Hook useMemo has an unnecessary dependency: 'isActive'. Either exclude it or remove the dependency array
|
|
Lint:
app/src/hooks/useMultiplayer.ts#L171
React Hook useEffect has a missing dependency: 'getStateForHash'. Either include it or remove the dependency array
|