fix(arhcived-project-tasks): only allow editing the project tasks when the project is not archived

Author: MitanOmar

backend/timed/permissions.py

@@ -65,6 +65,13 @@ def has_object_permission(self, request, view, _obj):
         return self.has_permission(request, view)
 
 
+class IsProjectActive(BasePermission):
+    """Allow Only the project that is not archived."""
+
+    def has_object_permission(self, _request, _view, task):
+        return not task.project.archived
+
+
 class IsAuthenticated(IsAuthenticated):
     """Support mixing permission IsAuthenticated with object permission.
 

backend/timed/projects/views.py

@@ -13,6 +13,7 @@
     IsCustomer,
     IsInternal,
     IsManager,
+    IsProjectActive,
     IsReadOnly,
     IsSuperUser,
     IsUpdateOnly,
@@ -177,6 +178,8 @@ class TaskViewSet(ModelViewSet):
         (
             # superuser may edit all tasks
             IsSuperUser
+            # only superuser can update tasks of archived projects
+            | (IsUpdateOnly & IsProjectActive)
             # managers may edit all tasks
             | IsManager
             # all authenticated users may read all tasks

frontend/app/projects/template.hbs

@@ -201,6 +201,7 @@
                 class="rounded"
                 data-test-name
                 @required={{true}}
+                @disabled={{this.selectedProject.archived}}
               />
 
               <f.input @labelComponent="void" @name="estimatedTime" as |fi|>
@@ -211,6 +212,7 @@
                   <Durationpicker
                     data-test-estimated-time={{true}}
                     @value={{fi.value}}
+                    @disabled={{this.selectedProject.archived}}
                     @onChange={{if
                       remainingEffortTracking
                       (queue fi.update (fn this.updateRemainingEffort f.model))
@@ -226,6 +228,7 @@
                 class="rounded"
                 data-test-reference
                 @required={{false}}
+                @disabled={{this.selectedProject.archived}}
               />
 
               {{#if remainingEffortTracking}}
@@ -244,6 +247,7 @@
                       @value={{fi.value}}
                       @min={{0}}
                       @onChange={{fi.update}}
+                      @disabled={{this.selectedProject.archived}}
                     />
                   </div>
                 </f.input>
@@ -257,6 +261,7 @@
                   @checked={{this.selectedTask.archived}}
                   @value={{fi.value}}
                   @onChange={{fi.update}}
+                  @disabled={{this.selectedProject.archived}}
                 />
               </f.input>
 
@@ -267,7 +272,17 @@
                   type="button"
                   {{on "click" (fn (mut this.selectedTask) null)}}
                 >Cancel</button>
-                <f.submit data-test-save @disabled={{f.model.isInvalid}} />
+                <f.submit
+                  data-test-save
+                  title={{if
+                    this.selectedProject.archived
+                    "You can not update or add tasks to an archived project"
+                  }}
+                  @disabled={{or
+                    f.model.isInvalid
+                    this.selectedProject.archived
+                  }}
+                />
               </div>
             </ValidatedForm>
           </div>