refactor: implement the change requests

Author: MitanOmar

frontend/app/components/topnav.hbs

@@ -92,7 +92,7 @@
           <Topnav::LinkTo
             @onClick={{fn (mut this.expand) false}}
             title="Open Timed documentation for current page"
-            href={{this.docs.docsEndpoint}}
+            href={{this.docs.endpoint}}
             target="_blank"
             data-test-docs-link
           >

frontend/app/services/docs.js

@@ -2,7 +2,7 @@ import Service, { service } from "@ember/service";
 
 import config from "timed/config/environment";
 
-const ROUTE_DOCS_MAPPING = {
+export const ROUTE_DOCS_MAPPING = {
   "index.attendances": "/tracking/attendances",
   "index.reports": "/tracking/timesheet",
   "analysis.index": "/analysis",
@@ -16,11 +16,11 @@ const ROUTE_DOCS_MAPPING = {
 export default class DocsService extends Service {
   @service router;
 
-  get docsEndpoint() {
+  get endpoint() {
     return config.docsBaseUrl + this.docsURL;
   }
 
   get docsURL() {
-    return ROUTE_DOCS_MAPPING[this.router.currentRouteName] || "";
+    return ROUTE_DOCS_MAPPING[this.router.currentRouteName] ?? "";
   }
 }

frontend/tests/acceptance/docs-test.js

@@ -5,6 +5,7 @@ import { authenticateSession } from "ember-simple-auth/test-support";
 import { module, test } from "qunit";
 
 import config from "timed/config/environment";
+import { ROUTE_DOCS_MAPPING } from "timed/services/docs";
 
 module("Acceptance | docs", function (hooks) {
   setupApplicationTest(hooks);
@@ -17,25 +18,18 @@ module("Acceptance | docs", function (hooks) {
   });
 
   test("Each route renders a link to the corresponding documentation page", async function (assert) {
-    const routes = {
-      "/attendances": "tracking/attendances",
-      "/reports": "tracking/timesheet",
-      "/analysis": "analysis",
-      "/statistics": "statistics",
-      "/projects": "projects",
-      "/users": "users",
-      "/": "tracking/activities",
-    };
-    const routesKey = Object.keys(routes);
+    const routesKey = Object.keys(ROUTE_DOCS_MAPPING);
+    const router = this.owner.lookup("service:router");
 
     for (const routeKey of routesKey) {
+      if (routeKey === "users.edit.index") continue;
       // eslint-disable-next-line no-await-in-loop
-      await visit(routeKey);
+      await visit(router.urlFor(routeKey));
       assert.dom("[data-test-docs-link]").exists();
 
       assert.strictEqual(
         document.querySelector("[data-test-docs-link]").href,
-        `${config.docsBaseUrl}/${routes[routeKey]}`,
+        `${config.docsBaseUrl}${ROUTE_DOCS_MAPPING[routeKey]}`,
       );
     }
   });