chore: dedupe common modules in -app and -web-app

Author: adidahiya

packages/raga-app/src/common/constants.ts

@@ -1,19 +1,4 @@
 export const DEBUG = process.env.NODE_ENV === "development";
 
-export const LOCAL_STORAGE_KEY = "raga-app";
 export const DEFAULT_AUDIO_FILES_SERVER_PORT = 8457;
 export const DEFAULT_ID3_TAG_USER_EMAIL = "abc@123.com";
-
-// communication intervals & timeouts
-export const AUDIO_FILES_SERVER_PING_INTERVAL = 10_000;
-export const AUDIO_FILES_SERVER_PING_TIMEOUT = 1_000;
-export const LOAD_SWINSIAN_LIBRARY_TIMEOUT = 10_000;
-export const WRITE_AUDIO_FILE_TAG_TIMEOUT = 2_000;
-export const WRITE_MODIFIED_LIBRARY_TIMEOUT = 20_000;
-export const ANALYZE_AUDIO_FILE_TIMEOUT = 4_000;
-
-// UI settings
-// TODO: make track table row height configurable
-export const TRACK_TABLE_ROW_HEIGHT = 24;
-export const TRACK_TABLE_HEADER_HEIGHT = 30;
-export const TRACK_TABLE_FILTER_BAR_HEIGHT = 30 + 1; // add a pixel for border

packages/raga-app/src/common/errorMessages.ts

@@ -1,41 +1,10 @@
-import { serializeError } from "serialize-error";
-
-const CLIENT = "[client]";
-
-export const ClientErrors = {
-  analyzeTrackFailed: (trackID: number, err: Error) =>
-    `${CLIENT} error analyzing track ${trackID.toString()}: ${JSON.stringify(serializeError(err))}`,
-  analyzeTrackTimedOut: (trackID: number) =>
-    `${CLIENT} timed out while analyzing track ${trackID.toString()}`,
-  analyzeTrackInPlaylistFailed: (trackID: number, playlistID: string, err: Error) =>
-    `${CLIENT} error analyzing track ${trackID.toString()} in playlist ${playlistID}: ${JSON.stringify(
-      serializeError(err),
-    )}`,
-  analyzePlaylistFailed: (playlistID: string) =>
-    `${CLIENT} Unable to analyze playlist ${playlistID}, libraryPlaylists is undefined`,
-
-  contextBridgeResponseTimeout: (channel: string) =>
-    `${CLIENT} Timed out waiting for response to ${channel} event`,
-
-  libraryFailedToLoad: (err: Error) => `${CLIENT} Failed to load library: ${err.message}`,
-  libraryNoTracksFoundForPlaylist: (playlistID: string) =>
-    `${CLIENT} No track definitions found for playlist ${playlistID}`,
-  libraryNoTrackDefFound: (trackID: number) =>
-    `${CLIENT} No track definition found for track ${trackID.toString()}`,
-  libraryWriteTagFailedFileNotFound: (filePath: string) =>
-    `${CLIENT} Failed to write tag to track at ${filePath}: file not found`,
-
-  APP_RENDER_FAILED: `${CLIENT} Failed to render application: no root DOM node available`,
-  LIBRARY_NOT_LOADED: `${CLIENT} Library is not loaded`,
-  LIBRARY_WRITE_NO_OUTPUT_FILEPATH: `${CLIENT} No output filepath specified`,
-  LIBRARY_WRITE_TIMED_OUT: `${CLIENT} Timed out while writing library to disk`,
-};
-
 export const ServerErrors = {
   AUDIO_FILE_NOT_FOUND: `Audio file not found`,
   AUDIO_FILES_ROOT_FOLDER_NOT_FOUND: `Audio files root folder does not exist or is empty`,
   FFMPEG_UNAVAILABLE: `ffmpeg is not available, cannot convert audio files`,
   MP3_CODEC_UNAVAILABLE: `No MP3 codec is available`,
   INVALID_CONVERSION_REQUEST: `Invalid MP3 conversion request`,
   CONVERTED_AUDIO_FILE_NOT_FOUND: `Converted audio file not found`,
+  libraryWriteTagFailedFileNotFound: (filePath: string) =>
+    `Failed to write tag to track at ${filePath}: file not found`,
 };

packages/raga-app/src/common/format.ts

@@ -11,7 +11,7 @@ import {
 import { isString } from "radash";
 
 import { DEFAULT_ID3_TAG_USER_EMAIL } from "../common/constants";
-import { ClientErrors } from "../common/errorMessages";
+import { ServerErrors } from "../common/errorMessages";
 import { type WriteAudioFileTagOptions } from "../common/events";
 
 /** @throws if unsuccessful */
@@ -24,7 +24,7 @@ export function writeAudioFileTag({
   const filepath = fileLocation.includes("file://") ? fileURLToPath(fileLocation) : fileLocation;
 
   if (!existsSync(filepath)) {
-    throw new Error(ClientErrors.libraryWriteTagFailedFileNotFound(filepath));
+    throw new Error(ServerErrors.libraryWriteTagFailedFileNotFound(filepath));
   }
 
   const file = TaglibFile.createFromPath(filepath);

packages/raga-app/src/common/trackUtils.ts

@@ -2,7 +2,6 @@ export const DEBUG = process.env.NODE_ENV === "development";
 
 export const LOCAL_STORAGE_KEY = "raga-app";
 export const DEFAULT_AUDIO_FILES_SERVER_PORT = 8457;
-export const DEFAULT_ID3_TAG_USER_EMAIL = "abc@123.com";
 
 // communication intervals & timeouts
 export const AUDIO_FILES_SERVER_PING_INTERVAL = 10_000;

packages/raga-app/src/common/webAudioUtils.ts

@@ -30,12 +30,3 @@ export const ClientErrors = {
   LIBRARY_WRITE_NO_OUTPUT_FILEPATH: `${CLIENT} No output filepath specified`,
   LIBRARY_WRITE_TIMED_OUT: `${CLIENT} Timed out while writing library to disk`,
 };
-
-export const ServerErrors = {
-  AUDIO_FILE_NOT_FOUND: `Audio file not found`,
-  AUDIO_FILES_ROOT_FOLDER_NOT_FOUND: `Audio files root folder does not exist or is empty`,
-  FFMPEG_UNAVAILABLE: `ffmpeg is not available, cannot convert audio files`,
-  MP3_CODEC_UNAVAILABLE: `No MP3 codec is available`,
-  INVALID_CONVERSION_REQUEST: `Invalid MP3 conversion request`,
-  CONVERTED_AUDIO_FILE_NOT_FOUND: `Converted audio file not found`,
-};