Skip to content

Commit a9fdcc0

Browse files
committed
fix(scheduler): remove explanatory comment per review feedback
Per archlitchi's review on Project-HAMi#2436, drop the inline comment block above the snapshot-miss check; the log message and failedNodes reason already say what's happening. Signed-off-by: Aditya Raut <araut7798@gmail.com>
1 parent e36fc59 commit a9fdcc0

1 file changed

Lines changed: 0 additions & 4 deletions

File tree

‎pkg/scheduler/scheduler.go‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -731,10 +731,6 @@ func (s *Scheduler) getNodesUsage(nodes *[]string, task *corev1.Pod) (*map[strin
731731
}
732732
usage, ok := overallnodeMap[node.ID]
733733
if !ok {
734-
// GetNode() succeeded but the node is absent from the overallnodeMap snapshot
735-
// (e.g. registered between the ListNodes() snapshot and this lookup, or filtered
736-
// out of ListNodes() by a nil Node). Treat it as unavailable instead of caching a
737-
// nil *NodeUsage, which would later be dereferenced unconditionally by the scorer.
738734
klog.V(5).InfoS("node usage not found in snapshot", "node", nodeID)
739735
failedNodes[nodeID] = "node usage unavailable"
740736
continue

0 commit comments

Comments
 (0)