Merge pull request #73 from adobe-rnd/remove-internal

fix: remove internal from json response

Author: dylandepass

src/product-json-pipe.js

@@ -68,7 +68,8 @@ export async function productJSONPipe(state, req) {
 
     setLastModified(state, res);
 
-    res.body = JSON.stringify(state.content.data, null, 2);
+    const { internal: _, ...productData } = state.content.data;
+    res.body = JSON.stringify(productData, null, 2);
   } catch (e) {
     const errorRes = new PipelineResponse('', {
       status: e instanceof PipelineStatusError ? e.code : 500,

test/fixtures/product/product-configurable.json

@@ -56,6 +56,12 @@
       }
     ]
   },
+  "internal": {
+    "images": [
+      { "url": "https://origin.example.com/product/images/original-a.png" },
+      { "url": "https://origin.example.com/product/images/original-b.png" }
+    ]
+  },
   "variants": [
     {
       "sku": "5000-BLK",

test/product-json-pipe.test.js

@@ -112,6 +112,37 @@ describe('Product JSON Pipe Test', () => {
     });
   });
 
+  it('strips the internal property from the json response', async () => {
+    const s3Loader = new FileS3Loader();
+
+    s3Loader.statusCodeOverrides = {
+      'product-configurable': 200,
+    };
+
+    s3Loader.headers('product-configurable', 'sku', 'product-configurable');
+
+    const state = DEFAULT_STATE({
+      log: console,
+      s3Loader,
+      ref: 'main',
+      path: '/products/product-configurable.json',
+      partition: 'live',
+      timer: {
+        update: () => { },
+      },
+    });
+    state.info = getPathInfo('/products/product-configurable.json');
+    const resp = await productJSONPipe(
+      state,
+      new PipelineRequest(new URL('https://acme.com/products/product-configurable.json')),
+    );
+    assert.strictEqual(resp.status, 200);
+
+    const body = JSON.parse(resp.body);
+    assert.strictEqual(body.internal, undefined, 'internal property must not be exposed');
+    assert.ok(body.name, 'product name should still be present');
+  });
+
   it('sends 400 for non json path', async () => {
     const state = DEFAULT_STATE({
       path: '/blog/article',