Skip to content

Commit 68bf503

Browse files
Copilotafranken
andcommitted
Add refactor skill cross-references to implement, test, and review skills
Co-authored-by: afranken <[email protected]>
1 parent 14d9325 commit 68bf503

File tree

3 files changed

+9
-5
lines changed

3 files changed

+9
-5
lines changed

.claude/skills/implement/SKILL.md

Lines changed: 7 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -9,11 +9,14 @@ description: Implement features, fix bugs, or refactor code. Use when asked to a
99
1010
## Skill Workflow
1111

12-
A complete feature implementation requires all three skills — run them in sequence:
12+
A complete feature implementation requires these skills — run them in sequence:
1313

14-
1. **implement** (this skill) — write the production code
15-
2. **test** skill — add/update unit and integration tests (`*Test.kt`, `*IT.kt`)
16-
3. **document** skill — update `CHANGELOG.md`, `README.md`, and `AGENTS.md` where applicable
14+
1. **refactor** skill — if nearby existing code, tests, or configuration would benefit from cleanup *before* adding new code, do it first rather than working around it
15+
2. **implement** (this skill) — write the production code
16+
3. **test** skill — add/update unit and integration tests (`*Test.kt`, `*IT.kt`)
17+
4. **document** skill — update `CHANGELOG.md`, `README.md`, and `AGENTS.md` where applicable
18+
19+
> **Prefer refactoring over workarounds**: if you find yourself adding complexity to work around existing code, stop and invoke the `refactor` skill to clean it up first.
1720
1821
## Implementation Flow for New S3 Operations
1922

.claude/skills/review/SKILL.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ See **[docs/KOTLIN.md](../../../docs/KOTLIN.md)** for the full list of idioms an
4848
Structure feedback as:
4949

5050
- **Must fix** — blocks merge (correctness issues, convention violations, missing tests)
51-
- **Should fix** — strongly recommended (idiom improvements, missing docs)
51+
- **Should fix** — strongly recommended (idiom improvements, missing docs); suggest invoking the **`refactor` skill** for purely readability/style improvements rather than asking the author to add more code
5252
- **Nit** — optional style suggestions
5353

5454
For each finding, reference the specific AGENTS.md rule or AWS API doc where applicable.

.claude/skills/test/SKILL.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ Read **[docs/TESTING.md](../../../docs/TESTING.md)**, **[docs/KOTLIN.md](../../.
1919
## Checklist
2020

2121
- [ ] Read `docs/TESTING.md` and root + module `AGENTS.md`
22+
- [ ] If existing tests have structural problems (poor naming, shared state, weak assertions), invoke the **`refactor` skill** to fix them rather than working around them
2223
- [ ] Tests pass locally
2324
- [ ] Both success and failure cases covered
2425
- [ ] Tests are independent (no shared state, UUID bucket names)

0 commit comments

Comments
 (0)