Merge pull request #2484 from adobe/2481-islatest-true-by-default

Always return "isLatest=true" if versioning is disabled

Author: afranken

CHANGELOG.md

@@ -9,6 +9,7 @@ Whenever a 3rd party library is updated, S3Mock will update it's MINOR version.
   * [Planned changes](#planned-changes)
 * [CURRENT - 4.x - THIS VERSION IS UNDER ACTIVE DEVELOPMENT](#current---4x---this-version-is-under-active-development)
   * [4.6.0 - PLANNED](#460---planned)
+  * [4.5.1](#451)
   * [4.5.0](#450)
   * [4.4.0](#440)
   * [4.3.0](#430)
@@ -157,6 +158,19 @@ Version 4.x is JDK17 LTS bytecode compatible, with Docker and JUnit / direct Jav
 * Version updates (build dependencies)
   * TBD
 
+## 4.5.1
+Version 4.x is JDK17 LTS bytecode compatible, with Docker and JUnit / direct Java integration.
+
+* Features and fixes
+  * ListObjectVersions API returns "isLatest=true" if versioning is not enabled. (fixes #2481)
+* Refactorings
+  * TBD
+* Version updates (deliverable dependencies)
+  * None
+* Version updates (build dependencies)
+  * Bump kotlin.version from 2.1.21 to 2.2.0
+  * Bump com.puppycrawl.tools:checkstyle from 10.25.0 to 10.26.0
+
 ## 4.5.0
 Version 4.x is JDK17 LTS bytecode compatible, with Docker and JUnit / direct Java integration.
 

integration-tests/src/test/kotlin/com/adobe/testing/s3mock/its/ListObjectVersionsIT.kt

@@ -127,8 +127,8 @@ internal class ListObjectVersionsIT : S3TestBase() {
     }.also {
       assertThat(it.versions())
         .hasSize(2)
-        .extracting("versionId")
-        .containsExactlyInAnyOrder("null", "null")
+        .extracting("versionId", "isLatest")
+        .containsExactly(Tuple("null", true), Tuple("null", true))
     }
   }
 

server/src/main/java/com/adobe/testing/s3mock/dto/ObjectVersion.java

@@ -47,7 +47,8 @@ public record ObjectVersion(
   public static ObjectVersion from(S3ObjectMetadata s3ObjectMetadata, boolean isLatest) {
     return new ObjectVersion(s3ObjectMetadata.checksumAlgorithm(),
         s3ObjectMetadata.checksumType(),
-        s3ObjectMetadata.etag(), isLatest,
+        s3ObjectMetadata.etag(),
+        isLatest,
         s3ObjectMetadata.key(),
         s3ObjectMetadata.modificationDate(),
         s3ObjectMetadata.owner(),
@@ -57,11 +58,14 @@ public static ObjectVersion from(S3ObjectMetadata s3ObjectMetadata, boolean isLa
         s3ObjectMetadata.versionId());
   }
 
+  /**
+   * Use if versioning is not enabled.
+   */
   public static ObjectVersion from(S3Object s3Object) {
     return new ObjectVersion(s3Object.checksumAlgorithm(),
         s3Object.checksumType(),
         s3Object.etag(),
-        false,
+        true,
         s3Object.key(),
         s3Object.lastModified(),
         s3Object.owner(),