Skip to content

Commit e1cb3cd

Browse files
committed
IT correctness
Test ITs against S3 again to see if there are differences in behaviour, fix S3Mock if necessary. # Conflicts: # integration-tests/src/test/kotlin/com/adobe/testing/s3mock/its/BucketIT.kt
1 parent 9318d60 commit e1cb3cd

File tree

2 files changed

+10
-3
lines changed

2 files changed

+10
-3
lines changed

integration-tests/src/test/kotlin/com/adobe/testing/s3mock/its/BucketIT.kt

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,8 +71,13 @@ internal class BucketIT : S3TestBase() {
7171
}
7272
}
7373

74+
/**
75+
* Not sure why S3 does not accept any combination of LocationInfo and BucketInfo in the configuration.
76+
* Requests always fail claiming that the XML is not well-formed, even though it is generated by their own SDK...
77+
*/
7478
@Test
75-
@S3VerifiedSuccess(year = 2025)
79+
@S3VerifiedFailure(year = 2025,
80+
reason = "The XML you provided was not well-formed or did not validate against our published schema")
7681
fun `creating a bucket with configuration is successful`(testInfo: TestInfo) {
7782
val bucketName = bucketName(testInfo)
7883
val createBucketResponse = s3Client.createBucket {

integration-tests/src/test/kotlin/com/adobe/testing/s3mock/its/PlainHttpIT.kt

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,8 @@ internal class PlainHttpIT : S3TestBase() {
112112
}
113113

114114
@Test
115-
@S3VerifiedSuccess(year = 2022)
115+
@S3VerifiedFailure(year = 2025,
116+
reason = "No credentials sent in plain HTTP request")
116117
fun createBucketWithDisallowedName() {
117118
HttpPut("$serviceEndpoint/$INVALID_BUCKET_NAME").also {
118119
httpClient.execute(it).use { response ->
@@ -222,7 +223,8 @@ internal class PlainHttpIT : S3TestBase() {
222223
}
223224

224225
@Test
225-
@S3VerifiedSuccess(year = 2022)
226+
@S3VerifiedFailure(year = 2025,
227+
reason = "No credentials sent in plain HTTP request")
226228
fun listBucketsUsesApplicationXmlContentType(testInfo: TestInfo) {
227229
givenBucket(testInfo)
228230
HttpGet("$serviceEndpoint$SLASH").also {

0 commit comments

Comments
 (0)