Skip to content

Commit e753b5f

Browse files
committed
Add test for cors headers for PUT
1 parent d232514 commit e753b5f

File tree

1 file changed

+16
-12
lines changed
  • integration-tests/src/test/kotlin/com/adobe/testing/s3mock/its

1 file changed

+16
-12
lines changed

integration-tests/src/test/kotlin/com/adobe/testing/s3mock/its/PlainHttpIT.kt

+16-12
Original file line numberDiff line numberDiff line change
@@ -176,19 +176,23 @@ internal class PlainHttpIT : S3TestBase() {
176176
@Test
177177
fun testCorsHeaders(testInfo: TestInfo) {
178178
val targetBucket = givenBucketV2(testInfo)
179-
val httpOptions = HttpOptions("$serviceEndpoint/$targetBucket").apply {
180-
this.setHeader(BasicHeader("Origin", "http://someurl.com"))
181-
this.setHeader(BasicHeader("Access-Control-Request-Method", "GET"))
182-
this.setHeader(BasicHeader("Access-Control-Request-Headers", "Content-Type, x-requested-with"))
183-
}
184179

185-
httpClient.execute(httpOptions).use {
186-
assertThat(it.getFirstHeader("Access-Control-Allow-Origin").value).isEqualTo("http://someurl.com")
187-
assertThat(it.getFirstHeader("Access-Control-Allow-Methods").value).isEqualTo("GET")
188-
assertThat(it.getFirstHeader("Access-Control-Allow-Headers").value)
189-
.isEqualTo("Content-Type, x-requested-with")
190-
assertThat(it.getFirstHeader("Access-Control-Allow-Credentials").value).isEqualTo("true")
191-
assertThat(it.getFirstHeader("Allow").value).contains("GET")
180+
arrayOf("GET", "PUT").forEach { method ->
181+
val httpOptions = HttpOptions("$serviceEndpoint/$targetBucket").apply {
182+
this.setHeader(BasicHeader("Origin", "http://someurl.com"))
183+
this.setHeader(BasicHeader("Access-Control-Request-Method", method))
184+
this.setHeader(BasicHeader("Access-Control-Request-Headers", "Content-Type, x-requested-with"))
185+
}
186+
187+
httpClient.execute(httpOptions).use {
188+
assertThat(it.statusLine.statusCode).isEqualTo(HttpStatus.SC_OK)
189+
assertThat(it.getFirstHeader("Access-Control-Allow-Origin").value).isEqualTo("http://someurl.com")
190+
assertThat(it.getFirstHeader("Access-Control-Allow-Methods").value).isEqualTo(method)
191+
assertThat(it.getFirstHeader("Access-Control-Allow-Headers").value)
192+
.isEqualTo("Content-Type, x-requested-with")
193+
assertThat(it.getFirstHeader("Access-Control-Allow-Credentials").value).isEqualTo("true")
194+
assertThat(it.getFirstHeader("Allow").value).contains(method)
195+
}
192196
}
193197
}
194198

0 commit comments

Comments
 (0)