Multipart upload with ChecksumType.FULL_OBJECT not working

[ackava]

As I have looked up the source code it seems ChecksumType.COMPOSITE is hardcoded in multi part upload so using ChecksumType.FULL_OBJECT fails on s3mock, but it does work correctly on aws s3.

ChecksumType.COMPOSITE

        // this fails with s3mock but works with aws s3
        await this.client.send(new CompleteMultipartUploadCommand({
            Bucket: this.Bucket,
            Key: this.Key,
            UploadId: uploadRequest.UploadId,
            ChecksumCRC64NVME: this.ChecksumCRC64NVME,
            ChecksumType: "FULL_OBJECT",
            MultipartUpload: {
                Parts
            }
        }));

instead of hardcoded composite, it should take full_object from the input parameter and support full_object checksum.

[afranken]

thanks for the report.
We indeed currently implement only "COMPOSITE" checksums for Multipart uploads.
"FULL_OBJECT" was added on later for Multipart uploads and S3Mock was never retrofitted.

I just pushed a fix that will be included in the first 5.x release and verified the new integration tests against S3 APIs.

[ackava]

@afranken Thank you for fixing this. This library is very useful for local testing.