Skip to content

Commit e563b2a

Browse files
committed
fix: use aside element for ideas features on ideas page
Wrap ideas feature sections within an aside, to improve accessibility tree and scope its headings so they do not apply to the same tier as the articles.
1 parent 7daedd8 commit e563b2a

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

blocks/ideas/ideas-functions.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ import { getCurrentFiltersArray } from "../filter-group/filter-group-utils.js";
2222
* Create markup for ideas feature section from data/content, and return it.
2323
* Title text is required.
2424
* @param {IdeasFeatureContent} featureContent
25-
* @returns {HTMLDivElement|null} Markup of feature, or null if missing required content.
25+
* @returns {HTMLElement|null} Markup of feature, or null if missing required content.
2626
*/
2727
export const buildIdeasFeature = (featureContent) => {
2828
// Check for required content.
@@ -32,7 +32,7 @@ export const buildIdeasFeature = (featureContent) => {
3232

3333
// Create markup.
3434
// This element is both a grid item for the larger page layout, and a grid container for its children.
35-
const feature = document.createElement("div");
35+
const feature = document.createElement("aside");
3636
feature.classList.add("grid-item", "grid-item--100", "ideas__feature");
3737

3838
// Content side which contains text elements and button.

0 commit comments

Comments
 (0)