fix: fix regressions.

Author: mohiaror

content/src/content/jcr_root/apps/core/wcm/components/image/v3/image/clientlibs/editor/js/image.js

@@ -653,6 +653,7 @@
             smartcrops = JSON.parse(responseText).repositoryMetadata.smartcrops;
         }
         if (smartcrops !== undefined) {
+            $dynamicMediaGroup.find(presetTypeSelector).parent().show();
             var smartcropnames = Object.keys(smartcrops);
             if (smartCropRenditionsDropDown.items) {
                 smartCropRenditionsDropDown.items.clear();
@@ -673,6 +674,7 @@
             prepareSmartCropPanel();
         } else {
             $dynamicMediaGroup.find(presetTypeSelector).parent().hide();
+            $dynamicMediaGroup.find(imagePresetDropDownSelector).parent().hide();
             hideSmartCropRenditionField();
         }
         showImageModifiersForRemoteAsset();

content/test/clientlibs/authoringutils/imageV3EditorRemoteAssetTest.js

@@ -118,7 +118,7 @@ describe("Image v3 editor remote asset Dynamic Media", function() {
     });
 
     describe("processPolarisSmartCropMetadataResponse", function() {
-        it("shows smart crop and image modifiers when smartcrops metadata is present", function() {
+        it("shows preset type, smart crop radio, smart crop dropdown, and image modifiers when smartcrops metadata is present", function() {
             const responseText = JSON.stringify({
                 repositoryMetadata: {
                     smartcrops: {
@@ -131,12 +131,37 @@ describe("Image v3 editor remote asset Dynamic Media", function() {
 
             const smartCrop = fixtureRoot.querySelector(".cmp-image__editor-dynamicmedia-smartcroprendition");
             const modifiers = fixtureRoot.querySelector("input[name='./imageModifiers']");
+            const presetType = fixtureRoot.querySelector(".cmp-image__editor-dynamicmedia-presettype");
+            const smartCropRadio = fixtureRoot.querySelector(
+                ".cmp-image__editor-dynamicmedia-presettype input[value='smartCrop']"
+            );
             expect(isGroupVisible(fixtureRoot)).toBe(true);
+            expect(isParentVisible(presetType)).toBe(true);
+            expect(smartCropRadio.checked).toBe(true);
             expect(isParentVisible(smartCrop)).toBe(true);
             expect(isParentVisible(modifiers)).toBe(true);
         });
 
-        it("shows image modifiers but hides smart crop and preset type when smartcrops metadata is absent", function() {
+        it("re-shows preset type after a previous no-smartcrops response had hidden it", function() {
+            const noSmartCrops = JSON.stringify({
+                repositoryMetadata: {}
+            });
+            const withSmartCrops = JSON.stringify({
+                repositoryMetadata: {
+                    smartcrops: {
+                        Landscape: { width: 16, height: 9 }
+                    }
+                }
+            });
+
+            api.processPolarisSmartCropMetadataResponse(200, noSmartCrops);
+            api.processPolarisSmartCropMetadataResponse(200, withSmartCrops);
+
+            const presetType = fixtureRoot.querySelector(".cmp-image__editor-dynamicmedia-presettype");
+            expect(isParentVisible(presetType)).toBe(true);
+        });
+
+        it("shows image modifiers but hides smart crop, image preset, and preset type when smartcrops metadata is absent", function() {
             const responseText = JSON.stringify({
                 repositoryMetadata: {}
             });
@@ -146,10 +171,12 @@ describe("Image v3 editor remote asset Dynamic Media", function() {
             const smartCrop = fixtureRoot.querySelector(".cmp-image__editor-dynamicmedia-smartcroprendition");
             const modifiers = fixtureRoot.querySelector("input[name='./imageModifiers']");
             const presetType = fixtureRoot.querySelector(".cmp-image__editor-dynamicmedia-presettype");
+            const imagePreset = fixtureRoot.querySelector(".cmp-image__editor-dynamicmedia-imagepreset");
             expect(isGroupVisible(fixtureRoot)).toBe(true);
             expect(isParentVisible(modifiers)).toBe(true);
             expect(isParentVisible(smartCrop)).toBe(false);
             expect(isParentVisible(presetType)).toBe(false);
+            expect(isParentVisible(imagePreset)).toBe(false);
         });
 
         it("keeps original preset behaviour by hiding image preset radio parent", function() {