[SITES-40889] [Core Components] Improve VCF placeholder copy and route literals through i18n()#3035
Merged
Conversation
…e literals through i18n()
- Author "no preview" placeholder: reword title from "Visual Content Fragment preview unavailable" to
"Visual Content Fragment unavailable" and drop the editor-specific detail suffix.
- Author "load failed" detail no longer references "preview services" (always available on publish)
or "fragment configuration" (opaque to authors); align with the publish-side wording
"The Visual Content Fragment could not be displayed."
- Move the literal strings inside i18n("...") calls at the placeholder-builder site so the
literals are visible to translation tooling, rather than being passed positionally and
translated inside the HTML builder.
- Update vcfRendererTest.js assertion to match the new title.
Co-authored-by: Cursor <cursoragent@cursor.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
YahorC
approved these changes
May 15, 2026
LSantha
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…