SITES-42542 - docs and integration test for Structured Data (JSON-LD) Injection in Page#3037
Merged
Conversation
…njection * document Structured Data (JSON-LD) injection feature in Page v1, v2, v3 README * list the inherited cq:structuredData edit dialog property in Page v3 README
…njection
* add minimal integration test verifying JSON-LD script tag is emitted in Page v3 head
* gate test with @RunIfToggleEnabled("FT_SITES-42542") so it is skipped when the feature toggle is off
* seed cq:structuredData on the existing simple-page-v3 test content
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
…njection * list cq:structuredData edit dialog property in Page v1 and v2 README
|
YahorC
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #3029, which wired
<sly data-sly-include="structureddata.html"></sly>into the Page v1/v2/v3head.htmlbut did not update docs or add a smoke test on this side.What this PR adds
Docs — Page v1/v2/v3
README.md:./cq:structuredDataproperty in the Edit Dialog Properties section.Integration test —
testing/it/http(Page v3PageIT):testStructuredDatathat GETssimple-page-v3.htmland asserts a<script type="application/ld+json">…</script>tag with the seeded JSON-LD block is present in the rendered output.@RunIfToggleEnabled("FT_SITES-42542")so it is skipped when the foundation feature toggle is off (same pattern asImageIT#testNgdmImage).cq:structuredDataon the existingsimple-page-v3test page (no new content node).Why minimal
Model-level behaviour (JSON compaction,
</escaping, toggle-off → empty list, multi-block ordering, etc.) is already covered byStructuredDataImplTestin the foundation bundle. This PR intentionally only smoke-tests the HTL wiring — one assertion that the script tag lands in<head>— to avoid duplicating that coverage. The wiring is identical across Page v1/v2/v3, so a single v3 case is sufficient.Verification
mvn test-compileontesting/it/http— passes.mvn packageontesting/it/it.ui.content— passes.SITES-42542work deployed andFT_SITES-42542enabled; otherwise it is skipped.Pull Request opened by Augment Code with guidance from the PR author