-
Notifications
You must be signed in to change notification settings - Fork 32
Open
Labels
enhancementNew feature or requestNew feature or request
Description
Right now, config validation is not turned on by default and only certain commands turn it on, like the app pack command:
| const appConfig = await libConfig.load({ validateAppConfig: true }) |
Modify BaseCommand.getFullConfig to validate the app config by default - this means that all commands that call getFullConfig will validate the config by default, even if they don't use the whole config:
https://github.com/search?q=repo%3Aadobe%2Faio-cli-plugin-app%20getFullConfig&type=code
BaseCommand.getFullConfig:
aio-cli-plugin-app/src/BaseCommand.js
Line 147 in 4fb2a25
| const validateAppConfig = options.validateAppConfig === true |
Provide a shared flag in the BaseCommand to turn off config validation, just in case there are issues:
- The flag should be called
config-validationandallowsNo : true,default: true. - The
getFullConfigmethod should read the flag directly - every command that inherits from BaseCommand must spread the
BaseCommandflags
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request