fix: put ttl option should throw an error if the value is a quoted number (string) (#72)

Author: shazron

lib/StateStore.js

@@ -122,7 +122,7 @@ class StateStore {
     const details = { key, value, options }
     validateKey(key, details)
     validateValue(value, details)
-    validateInput(options, joi.object().label('options').keys({ ttl: joi.number() }), details)
+    validateInput(options, joi.object().label('options').keys({ ttl: joi.number() }).options({ convert: false }), details)
 
     const ttl = options.ttl || StateStore.DefaultTTL // => undefined, null, 0 sets to default
     logger.debug(`put '${key}' with ttl ${ttl}`)

test/StateStore.test.js

@@ -66,6 +66,7 @@ describe('put', () => {
     await global.expectToThrowBadArg(state.put.bind(state, 'key', 'value', 'options'), ['object', 'options'], { ...expectedDetails, options: 'options' })
     await global.expectToThrowBadArg(state.put.bind(state, 'key', 'value', { nonexiting__option: 'value' }), ['nonexiting__option', 'not allowed'], { ...expectedDetails, options: { nonexiting__option: 'value' } })
     await global.expectToThrowBadArg(state.put.bind(state, 'key', 'value', { ttl: 'value' }), ['ttl', 'number'], { ...expectedDetails, options: { ttl: 'value' } })
+    await global.expectToThrowBadArg(state.put.bind(state, 'key', 'value', { ttl: '1' }), ['ttl', 'number'], { ...expectedDetails, options: { ttl: '1' } })
   })
   test('calls _put with default ttl when options is undefined or options.ttl is = 0', async () => {
     const state = new StateStore(true)