Skip to content

Commit 45c77a4

Browse files
author
saville
committed
Fix running buildrunner in docker, and deprecate this functionality
1 parent 9dfed5a commit 45c77a4

File tree

4 files changed

+17
-4
lines changed

4 files changed

+17
-4
lines changed

Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,5 +54,5 @@ RUN uv sync --locked --no-dev
5454
# apt-get update; \
5555
# apt-get -y install docker-engine
5656

57-
ENTRYPOINT ["uv", "run", "buildrunner"]
57+
ENTRYPOINT ["uv", "--project", "/app", "run", "--no-sync", "buildrunner"]
5858
CMD []

docs/installation.rst

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,8 @@ To install Buildrunner, run the following command:
2727
2828
The buildrunner executable is now available in your path.
2929

30-
Alternatively, you can use the ``uvx`` command to run buildrunner:
30+
Alternatively, you can use the ``uvx`` command to run buildrunner directly which will automatically download and
31+
install buildrunner into an isolated environment, which is then cached for subsequent runs:
3132

3233
.. code:: bash
3334
@@ -51,6 +52,11 @@ The buildrunner executable is now available via ``uv run buildrunner``.
5152
Docker Container
5253
################
5354

55+
.. warning::
56+
This method of running buildrunner is now deprecated in favor of using Astral UV
57+
as described above. The scripts may be removed in a future release and a warning has been
58+
added to all script runs.
59+
5460
Buildrunner can be run as a Docker container. This works cross-platform and
5561
is the easiest way to keep up to date.
5662

@@ -64,8 +70,7 @@ is the easiest way to keep up to date.
6470

6571
You can now use the ``buildrunner`` command to run buildrunner in a Docker container.
6672

67-
.. note:: WINDOWS USERS: This is the recommended method for Windows users, however, you must make
68-
sure that you are using the `BASH shell
73+
.. note:: WINDOWS USERS: Make sure that you are using the `BASH shell
6974
<https://www.laptopmag.com/articles/use-bash-shell-windows-10>`_ enhancements for Windows or that
7075
you have something installed that enables the use of ``sh``, or else this method will not work.
7176
If you are using WSL and the hyper-v installation of docker:

scripts/buildrunner

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,10 @@ else
2020
docker_sock="//var/run/docker.sock"
2121
fi
2222

23+
echo "WARNING: This script is being deprecated and will be removed in a future release."
24+
echo " Please install uv (https://docs.astral.sh/uv/getting-started/installation)"
25+
echo " and then run 'uv tool install buildrunner' or 'uvx buildrunner' as documented"
26+
echo " here: https://github.com/adobe/buildrunner/blob/main/docs/installation.rst"
2327
docker run \
2428
$env_vars \
2529
-v /$HOME:$HOME \

scripts/buildrunnerOSXCredStore

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,10 @@ else
2828
docker_sock="//var/run/docker.sock"
2929
fi
3030

31+
echo "WARNING: This script is being deprecated and will be removed in a future release."
32+
echo " Please install uv (https://docs.astral.sh/uv/getting-started/installation)"
33+
echo " and then run 'uv tool install buildrunner' or 'uvx buildrunner' as documented"
34+
echo " here: https://github.com/adobe/buildrunner/blob/main/docs/installation.rst"
3135
docker run \
3236
$env_vars \
3337
-v /$HOME:$HOME \

0 commit comments

Comments
 (0)