Skip to content

Commit efd62b9

Browse files
committed
Move and retry flaky scan test
1 parent 40031c3 commit efd62b9

File tree

4 files changed

+9
-8
lines changed

4 files changed

+9
-8
lines changed

test_requirements.in

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,3 +7,4 @@ ruff>=0.1.7
77
ruff-lsp>=0.0.45
88
# Python 3.8 only supports up to 3.5.0
99
pre-commit<3.6
10+
pytest-rerunfailures>=14.0

test_requirements.txt

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ nodeenv==1.8.0
3535
packaging==23.1
3636
# via
3737
# pytest
38+
# pytest-rerunfailures
3839
# ruff-lsp
3940
platformdirs==3.5.1
4041
# via virtualenv
@@ -49,11 +50,14 @@ pytest==7.3.1
4950
# -r test_requirements.in
5051
# pytest-cov
5152
# pytest-randomly
53+
# pytest-rerunfailures
5254
# pytest-xdist
5355
pytest-cov==4.1.0
5456
# via -r test_requirements.in
5557
pytest-randomly==3.12.0
5658
# via -r test_requirements.in
59+
pytest-rerunfailures==14.0
60+
# via -r test_requirements.in
5761
pytest-xdist==3.3.1
5862
# via -r test_requirements.in
5963
pyyaml==6.0.1

tests/test_buildrunner_files.py

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
"test-general-buildx.yaml",
2020
"test-general.yaml",
2121
"test-push-artifact-buildx.yaml",
22-
"test-security-scan.yaml",
2322
]
2423

2524

@@ -186,14 +185,11 @@ def test_buildrunner_arm_dir(test_dir: str, file_name, args, exit_code):
186185
_test_buildrunner_file(test_dir, file_name, args, exit_code)
187186

188187

189-
@pytest.mark.serial
190-
@pytest.mark.skipif(
191-
"arm64" not in platform.uname().machine,
192-
reason="This test should only be run on arm64 architecture",
193-
)
188+
@pytest.mark.flaky(reruns=2, reruns_delay=1)
194189
@pytest.mark.parametrize(
195190
"test_dir, file_name, args, exit_code",
196-
_get_test_runs(test_dir=f"{TEST_DIR}/test-files/arm-arch", serial_tests=True),
191+
_get_test_runs(test_dir=f"{TEST_DIR}/test-files/scan", serial_tests=False),
197192
)
198-
def test_serial_buildrunner_arm_dir(test_dir: str, file_name, args, exit_code):
193+
def test_buildrunner_scan_dir(test_dir: str, file_name, args, exit_code):
194+
# The scan tests can be flaky, with errors like "TOOMANYREQUESTS: retry-after: 804.543µs, allowed: 44000/minute"
199195
_test_buildrunner_file(test_dir, file_name, args, exit_code)

0 commit comments

Comments
 (0)