fix(esbuild): avoid using createRequire as import name (#799)

* fix(esbuild): avoid usingcreateRequire as import name

* fix: don't use HELIX_FETCH_FORCE_HTTP1 (other projects might use this)

Author: dominique-pfister

src/bundler/ESBuildBundler.js

@@ -61,8 +61,8 @@ export default class ESBuildBundler extends BaseBundler {
       ],
       banner: {
         js: [
-          'import { createRequire } from "module";',
-          'const require = createRequire(import.meta.url);',
+          'import { createRequire as hedyCreateRequire } from "module";',
+          'const require = hedyCreateRequire(import.meta.url);',
           '',
         ].join('\n'),
       },
@@ -74,10 +74,17 @@ export default class ESBuildBundler extends BaseBundler {
         name: 'alias-main',
         setup: (build) => {
           build.onResolve({ filter: /^\.\/main\.js$/ }, () => ({ path: cfg.file }));
-          // use @adobe/helix-universal in the calling service, not ours
           build.onResolve(
             { filter: /^@adobe\/helix-universal$/ },
-            (args) => ({ path: path.resolve(cfg.cwd, 'node_modules', args.path, 'src', 'index.js') }),
+            (args) => {
+              const cwd = (process.env.HELIX_DEPLOY_USE_LOCAL === 'true')
+                // for testing use "our" @adobe/helix-universal dependency
+                ? path.resolve(__dirname, '..', '..')
+                // for production use @adobe/helix-universal (and its dependencies)
+                // in the calling service
+                : cfg.cwd;
+              return { path: path.resolve(cwd, 'node_modules', args.path, 'src', 'index.js') };
+            },
           );
           cfg.externals.forEach((filter) => {
             build.onResolve({ filter }, (args) => ({ path: args.path, external: true }));

src/template/node-index.mjs

@@ -22,4 +22,4 @@ export default {
   openwhisk,
   lambda,
   google,
-}
+};

test/build.test.js

@@ -167,4 +167,12 @@ describe('Build Test', () => {
   it('generates the bundle (esm, webpack) fails', async () => {
     await assert.rejects(generate(['--esm']), Error('Webpack bundler does not support ESM builds.'));
   }).timeout(5000);
+
+  it('generates the bundle (esm, esbuild)', async () => {
+    await generate(['--bundler=esbuild', '--esm'], PROJECT_SIMPLE_ESM);
+  });
+
+  it('generates the bundle (esbuild) fails', async () => {
+    await assert.rejects(generate(['--bundler=esbuild']), Error('ESBuild bundler only supports ESM builds.'));
+  });
 });

test/setup-env.js

@@ -9,12 +9,13 @@
  * OF ANY KIND, either express or implied. See the License for the specific language
  * governing permissions and limitations under the License.
  */
-// eslint-disable-next-line no-console
 import path from 'path';
 import { fileURLToPath } from 'url';
 
+// eslint-disable-next-line no-console
 console.log('Forcing HTTP/1.1 for @adobe/fetch');
 process.env.HELIX_FETCH_FORCE_HTTP1 = 'true';
+process.env.HELIX_DEPLOY_USE_LOCAL = 'true';
 
 // eslint-disable-next-line no-underscore-dangle
 global.__rootdir = path.resolve(fileURLToPath(import.meta.url), '..', '..');