Skip to content

Commit df2d160

Browse files
authored
Warn if insecure vault endpoint is used (#53)
1 parent 78f7273 commit df2d160

File tree

2 files changed

+6
-2
lines changed

2 files changed

+6
-2
lines changed

examples/secrets/default.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,3 @@
1+
---
2+
secret_path_v2: "{{vault.path(/kv2_secret)}}"
3+
secret_key_v2: "{{vault.key(/kv2_secret/key)}}"

himl/simplevault.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,9 @@ def get_vault_client(self):
2626
namespace = os.getenv('VAULT_NAMESPACE')
2727
verify = not strtobool(os.getenv('VAULT_SKIP_VERIFY', 'false'))
2828

29-
logger.info("Vault using url: {}, namespace: {}, verify: {}".format(url, namespace, verify))
29+
logger.info("Vault using url: {}, namespace: {}".format(url, namespace))
30+
if not verify:
31+
logger.warning("Using insecure vault endpoint, verify: {}".format(verify))
3032

3133
client = hvac.Client(
3234
url=url,
@@ -76,7 +78,6 @@ def get_path(self, path):
7678

7779
def get_key(self, path, key):
7880
secret_data = self.get_path(path)
79-
print(secret_data)
8081
secret_key_value = secret_data[key]
8182

8283
return secret_key_value

0 commit comments

Comments
 (0)