Fix hot reload and gosec issues (#7)

Author: adriananeci

cmd/root.go

@@ -33,7 +33,6 @@ var (
 	cfg                          config.Config
 	appContext                   *utils.AppContext
 	scheduler                    *gocron.Scheduler
-	configChangeCallback         func()
 
 	rootCmd = &cobra.Command{
 		Use:              "k8s-shredder",
@@ -122,12 +121,10 @@ func discoverConfig() {
 	viper.WatchConfig()
 	viper.OnConfigChange(func(e fsnotify.Event) {
 		log.Infof("Configuration file `%s` changed, attempting to reload", e.Name)
-		if configChangeCallback != nil {
-			reset()
-			parseConfig()
-			configChangeCallback()
-			run(&cobra.Command{}, []string{})
-		}
+		reset()
+		parseConfig()
+		appContext.Config = cfg
+		run(&cobra.Command{}, []string{})
 	})
 }
 

pkg/metrics/types.go

@@ -14,6 +14,7 @@ package metrics
 import (
 	"fmt"
 	"net/http"
+	"time"
 
 	log "github.com/sirupsen/logrus"
 
@@ -63,8 +64,13 @@ func serve(port int) error {
 		}
 	})
 
+	server := &http.Server{
+		Addr:              fmt.Sprintf(":%d", port),
+		ReadHeaderTimeout: 3 * time.Second,
+	}
+
 	go func() {
-		log.Fatal(http.ListenAndServe(fmt.Sprintf(":%d", port), nil))
+		log.Fatal(server.ListenAndServe(), nil)
 	}()
 	return nil
 }