Fix a bug when computing the rolling restart threshold (#10)

adriananeci · web-flow · commit b43829001a6e · 2022-10-06T13:41:56.000+03:00
diff --git a/pkg/handler/handler.go b/pkg/handler/handler.go
@@ -190,7 +190,7 @@ func (h *Handler) processNode(node v1.Node, rr chan *controllerObject) error {
 		}
 
 		if h.appContext.Config.NamespacePrefixSkipInitialEviction == "" || !strings.HasPrefix(pod.Namespace, h.appContext.Config.NamespacePrefixSkipInitialEviction) {
-			rrThresholdTime := -h.appContext.Config.ParkedNodeTTL * time.Duration(100-h.appContext.Config.RollingRestartThreshold*100) / 100
+			rrThresholdTime := h.appContext.Config.ParkedNodeTTL * time.Duration(100-h.appContext.Config.RollingRestartThreshold*100) / 100
 			if time.Now().UTC().Before(expiresOn.Add(-rrThresholdTime)) {
 				err := h.evictPod(pod, deleteOptions)
 				if err != nil {

Original file line number	Diff line number	Diff line change
`@@ -190,7 +190,7 @@ func (h Handler) processNode(node v1.Node, rr chan controllerObject) error {`
`190`	`190`	`}`
`191`	`191`
`192`	`192`	`if h.appContext.Config.NamespacePrefixSkipInitialEviction == "" \|\| !strings.HasPrefix(pod.Namespace, h.appContext.Config.NamespacePrefixSkipInitialEviction) {`
`193`		`- rrThresholdTime := -h.appContext.Config.ParkedNodeTTL * time.Duration(100-h.appContext.Config.RollingRestartThreshold*100) / 100`
	`193`	`+ rrThresholdTime := h.appContext.Config.ParkedNodeTTL * time.Duration(100-h.appContext.Config.RollingRestartThreshold*100) / 100`
`194`	`194`	`if time.Now().UTC().Before(expiresOn.Add(-rrThresholdTime)) {`
`195`	`195`	`err := h.evictPod(pod, deleteOptions)`
`196`	`196`	`if err != nil {`