Skip to content

Commit 6e187e5

Browse files
author
Cameron Wright
committed
adding conditional to check if kraft mode is enabled before selecting which expected results in test
1 parent 40c49d8 commit 6e187e5

File tree

1 file changed

+78
-36
lines changed

1 file changed

+78
-36
lines changed

controllers/tests/kafkacluster_controller_kafka_test.go

Lines changed: 78 additions & 36 deletions
Original file line numberDiff line numberDiff line change
@@ -525,48 +525,90 @@ func expectKafkaCRStatus(ctx context.Context, kafkaCluster *v1beta1.KafkaCluster
525525
Expect(kafkaCluster.Status.State).To(Equal(v1beta1.KafkaClusterRunning))
526526
Expect(kafkaCluster.Status.AlertCount).To(Equal(0))
527527

528-
Expect(kafkaCluster.Status.ListenerStatuses).To(Equal(v1beta1.ListenerStatuses{
529-
InternalListeners: map[string]v1beta1.ListenerStatusList{
530-
"internal": {
531-
{
532-
Name: "any-broker",
533-
Address: fmt.Sprintf("%s-all-broker.%s.svc.cluster.local:29092", kafkaCluster.Name, kafkaCluster.Namespace),
534-
},
535-
{
536-
Name: "broker-0",
537-
Address: fmt.Sprintf("%s-0.%s.svc.cluster.local:29092", kafkaCluster.Name, kafkaCluster.Namespace),
538-
},
539-
// {
540-
// Name: "broker-1",
541-
// Address: fmt.Sprintf("%s-1.%s.svc.cluster.local:29092", kafkaCluster.Name, kafkaCluster.Namespace),
542-
// },
543-
{
544-
Name: "broker-2",
545-
Address: fmt.Sprintf("%s-2.%s.svc.cluster.local:29092", kafkaCluster.Name, kafkaCluster.Namespace),
528+
if kafkaCluster.Spec.KRaftMode == false {
529+
Expect(kafkaCluster.Status.ListenerStatuses).To(Equal(v1beta1.ListenerStatuses{
530+
InternalListeners: map[string]v1beta1.ListenerStatusList{
531+
"internal": {
532+
{
533+
Name: "any-broker",
534+
Address: fmt.Sprintf("%s-all-broker.%s.svc.cluster.local:29092", kafkaCluster.Name, kafkaCluster.Namespace),
535+
},
536+
{
537+
Name: "broker-0",
538+
Address: fmt.Sprintf("%s-0.%s.svc.cluster.local:29092", kafkaCluster.Name, kafkaCluster.Namespace),
539+
},
540+
{
541+
Name: "broker-1",
542+
Address: fmt.Sprintf("%s-1.%s.svc.cluster.local:29092", kafkaCluster.Name, kafkaCluster.Namespace),
543+
},
544+
{
545+
Name: "broker-2",
546+
Address: fmt.Sprintf("%s-2.%s.svc.cluster.local:29092", kafkaCluster.Name, kafkaCluster.Namespace),
547+
},
546548
},
547549
},
548-
},
549-
ExternalListeners: map[string]v1beta1.ListenerStatusList{
550-
"test": {
551-
{
552-
Name: "any-broker",
553-
Address: "test.host.com:29092",
554-
},
555-
{
556-
Name: "broker-0",
557-
Address: "test.host.com:19090",
550+
ExternalListeners: map[string]v1beta1.ListenerStatusList{
551+
"test": {
552+
{
553+
Name: "any-broker",
554+
Address: "test.host.com:29092",
555+
},
556+
{
557+
Name: "broker-0",
558+
Address: "test.host.com:19090",
559+
},
560+
{
561+
Name: "broker-1",
562+
Address: "test.host.com:19091",
563+
},
564+
{
565+
Name: "broker-2",
566+
Address: "test.host.com:19092",
567+
},
558568
},
559-
{
560-
Name: "broker-1",
561-
Address: "test.host.com:19091",
569+
},
570+
}))
571+
}
572+
if kafkaCluster.Spec.KRaftMode == true {
573+
Expect(kafkaCluster.Status.ListenerStatuses).To(Equal(v1beta1.ListenerStatuses{
574+
InternalListeners: map[string]v1beta1.ListenerStatusList{
575+
"internal": {
576+
{
577+
Name: "any-broker",
578+
Address: fmt.Sprintf("%s-all-broker.%s.svc.cluster.local:29092", kafkaCluster.Name, kafkaCluster.Namespace),
579+
},
580+
{
581+
Name: "broker-0",
582+
Address: fmt.Sprintf("%s-0.%s.svc.cluster.local:29092", kafkaCluster.Name, kafkaCluster.Namespace),
583+
},
584+
{
585+
Name: "broker-2",
586+
Address: fmt.Sprintf("%s-2.%s.svc.cluster.local:29092", kafkaCluster.Name, kafkaCluster.Namespace),
587+
},
562588
},
563-
{
564-
Name: "broker-2",
565-
Address: "test.host.com:19092",
589+
},
590+
ExternalListeners: map[string]v1beta1.ListenerStatusList{
591+
"test": {
592+
{
593+
Name: "any-broker",
594+
Address: "test.host.com:29092",
595+
},
596+
{
597+
Name: "broker-0",
598+
Address: "test.host.com:19090",
599+
},
600+
{
601+
Name: "broker-1",
602+
Address: "test.host.com:19091",
603+
},
604+
{
605+
Name: "broker-2",
606+
Address: "test.host.com:19092",
607+
},
566608
},
567609
},
568-
},
569-
}))
610+
}))
611+
}
570612
for _, brokerState := range kafkaCluster.Status.BrokersState {
571613
Expect(brokerState.Version).To(Equal("3.4.1"))
572614
Expect(brokerState.Image).To(Equal(kafkaCluster.Spec.GetClusterImage()))

0 commit comments

Comments
 (0)