Skip to content

Commit 9446f00

Browse files
committed
Remove control.plane.listener.name property from broker during migration
1 parent 672c2f8 commit 9446f00

File tree

1 file changed

+2
-7
lines changed

1 file changed

+2
-7
lines changed

pkg/resources/kafka/configmap.go

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -165,17 +165,12 @@ func configureBrokerKRaftMode(bConfig *v1beta1.BrokerConfig, brokerID int32, kaf
165165
log.Error(err, fmt.Sprintf(kafkautils.BrokerConfigErrorMsgTemplate, kafkautils.KafkaConfigProcessRoles))
166166
}
167167
} else { // use zk mode for broker.
168-
// when in zk mode, "broker.id" and "control.plane.listener.name" are configured so it will communicate with zookeeper
168+
// when in zk mode, "broker.id" and "zookeeper.connect" are configured so it will communicate with zookeeper
169+
// control.plane.listener.name will not be set in zk mode. There for it will default to the interbroker listener.
169170
if err := config.Set(kafkautils.KafkaConfigBrokerID, brokerID); err != nil {
170171
log.Error(err, fmt.Sprintf(kafkautils.BrokerConfigErrorMsgTemplate, kafkautils.KafkaConfigBrokerID))
171172
}
172173

173-
if controllerListenerName != "" {
174-
if err := config.Set(kafkautils.KafkaConfigControlPlaneListener, controllerListenerName); err != nil {
175-
log.Error(err, fmt.Sprintf(kafkautils.BrokerConfigErrorMsgTemplate, kafkautils.KafkaConfigControlPlaneListener))
176-
}
177-
}
178-
179174
if err := config.Set(kafkautils.KafkaConfigZooKeeperConnect, zookeeperutils.PrepareConnectionAddress(
180175
kafkaCluster.Spec.ZKAddresses, kafkaCluster.Spec.GetZkPath())); err != nil {
181176
log.Error(err, fmt.Sprintf(kafkautils.BrokerConfigErrorMsgTemplate, kafkautils.KafkaConfigZooKeeperConnect))

0 commit comments

Comments
 (0)