[FIX] Add global check for ops min version

Author: costimuraru

src/ops/__init__.py

@@ -8,11 +8,21 @@
 #OF ANY KIND, either express or implied. See the License for the specific language
 #governing permissions and limitations under the License.
 
+import pkg_resources
 import re
+from distutils.version import StrictVersion
 from subprocess import call, Popen, PIPE
 from ops.cli import display
 
 
+def validate_ops_version(min_ops_version):
+    current_ops_version = [x.version for x in pkg_resources.working_set if x.project_name == "ops"][0]
+    if StrictVersion(current_ops_version) < StrictVersion(min_ops_version):
+        raise Exception("The current ops version {0} is lower than the minimum required version {1}. "
+                        "Please upgrade by following the instructions seen here: "
+                        "https://github.com/adobe/ops-cli#installing".format(current_ops_version, min_ops_version))
+
+
 class Executor(object):
     """ All cli commands usually return a dict(command=...) that will be executed by this handler"""
 

src/ops/cli/terraform.py

@@ -15,6 +15,7 @@
 from ops.terraform.terraform_cmd_generator import TerraformCommandGenerator
 from ops.hierarchical.composition_config_generator import TerraformConfigGenerator
 from distutils.version import StrictVersion
+from ops import validate_ops_version
 import pkg_resources
 
 logger = logging.getLogger(__name__)
@@ -144,10 +145,7 @@ def check_ops_version(self):
         if "terraform" in self.cluster_config.conf:
             if "ops_min_version" in self.cluster_config.conf["terraform"]:
                 ops_min_version = str(self.cluster_config.conf["terraform"]["ops_min_version"])
-                current_ops_version = [x.version for x in pkg_resources.working_set if  x.project_name == "ops"][0]
-                if StrictVersion(current_ops_version) < StrictVersion(ops_min_version):
-                    raise Exception("The current ops version {0} is lower than the minimum required version {1} for cluster {2}".format(
-                current_ops_version, ops_min_version, self.cluster_config_path))
+                validate_ops_version(ops_min_version)
 
     def run(self, args):
         self.check_ops_version()

src/ops/main.py

@@ -30,7 +30,7 @@
     PluginInventoryGenerator, InventoryGenerator, CachedInventoryGenerator
 from inventory.plugin import ec2, legacy_pcs, cns, azr, skms
 from inventory.sshconfig import SshConfigGenerator
-from ops import OpsException, Executor
+from ops import OpsException, Executor, validate_ops_version
 from ops.jinja import Template
 from opsconfig import OpsConfig
 
@@ -72,6 +72,7 @@ def __init__(self, argv=None):
         self.execute = auto(Executor)
 
         self.configure()
+        self.validate_ops_version()
 
     def configure_parsers(self):
         self.root_parser = auto(RootParser)
@@ -130,6 +131,10 @@ def configure(self):
 
         return args
 
+    def validate_ops_version(self):
+        if 'ops.min_version' in self.ops_config:
+            validate_ops_version(self.ops_config['ops.min_version'])
+
     def run(self):
         if 'refresh_cache' in vars(self.console_args):
             os.environ['REFRESH_CACHE'] = str(self.console_args.refresh_cache)