some important stability improvements

Author: sparecycles

packages/core/src/core/formats/kv-fmt.ts

@@ -14,6 +14,7 @@ import { JSON } from "../json.js";
 import {
   createNumber,
   isScalar,
+  isValidNumberToken,
   scalarTypeOf,
 } from "../schema/definition/scalar.js";
 
@@ -86,10 +87,7 @@ export const KV: {
           return JSON.parse(
             `"${token.slice(1, -1).replace(/\\.|\\'|"|\n/g, (match) => ({ [`\\'`]: `'`, [`"`]: `\\"`, ["\n"]: "\\n" })[match] ?? match)}"`,
           );
-        // 0, 100, 1.1e+10, 1.1e-10
-        case /^-?(?:0|[1-9][0-9]*(?:[.][0-9]+)?)(?:e[-+]?[0-9]+)?$/i.test(
-          token,
-        ):
+        case isValidNumberToken(token):
           return createNumber(token);
         case /^[+-]/.test(token):
           throw new Error("invalid numeric: " + token);

packages/core/src/core/schema/definition/scalar.ts

@@ -52,6 +52,10 @@ export function convertScalar(
         return createNumber(value["source"]);
       }
 
+      if (typeof value === 'string' && !isValidNumberToken(value)) {
+        return value;
+      }
+
       return unboxed ? Number(value) : createNumber(String(value));
     case "string":
       return String(value);
@@ -113,6 +117,13 @@ export function scalarTypeOf(value?: unknown): ScalarType | undefined {
             : (typeof value as ScalarType);
 }
 
+// 0, 100, 1.1e+10, 1.1e-10
+const numberRegex = /^-?(?:0|[1-9][0-9]*(?:[.][0-9]+)?)(?:e[-+]?[0-9]+)?$/;
+
+export function isValidNumberToken(n: string) {
+  return numberRegex.test(n);
+}
+
 export function createNumber(source: string, value?: number) {
   const numberObject = Object.assign(new Number(value ?? source), { source });