core: update rollup + favor: fix dev again

Author: sparecycles

packages/core/exports.d.ts

@@ -14,4 +14,8 @@ interface Promise<T> {
   await: T;
 }
 
-export let environment: Record<string, unknown>;
+declare global {
+  export let environment: Record<string, unknown>;
+}
+
+export {};

packages/core/package-lock.json

@@ -105,7 +105,7 @@
     "patch-package": "^8.0.0",
     "postcss-load-config": "^6.0.1",
     "prettier": "^3.2.5",
-    "rollup": "^4.17.2",
+    "rollup": "^4.27.2",
     "rollup-plugin-dts": "^6.1.0",
     "rollup-plugin-esbuild": "^6.1.0",
     "rollup-plugin-generate-package-json": "^3.2.0",

packages/core/package.json

@@ -49,7 +49,7 @@ export default [
   ({ dir, types, input }) =>
     /** @type {import("rollup").RollupOptions} */ ({
       input,
-      treeshake: true,
+      treeshake: types,
       output: {
         dir,
         format: "es",

packages/core/rollup.config.mjs

@@ -47,10 +47,6 @@ import { cleanObject } from "../../../util/clean-object.js";
 import { KV } from "../../../core/formats/kv-fmt.js";
 import { PardonError } from "../../../core/error.js";
 
-declare global {
-  let environment: Record<string, unknown>;
-}
-
 export type TestSetup = {
   test: () => Promise<void>;
   testcase: string;

packages/core/src/entry/testing/cli/runner.ts

@@ -10,6 +10,7 @@ OF ANY KIND, either express or implied. See the License for the specific languag
 governing permissions and limitations under the License.
 */
 import { tracking } from "../core/tracking.js";
+import "../../exports.js";
 
 export async function initTrackingEnvironment() {
   const { awaited: environmentUpdates, track: trackEnvironmentUpdate } =

packages/core/src/runtime/environment.ts

@@ -33,29 +33,25 @@ interface ForgedConfigEnv<
   forgeConfigSelf: VitePluginConfig[K][number];
 }
 
-export function extendMainConfig(
-  config: UserConfigExport,
-  target?: "es" | "cjs",
-): UserConfigExport {
+export function extendMainConfig(config: UserConfigExport): UserConfigExport {
   return async (env: ConfigEnv) =>
     await applyBaseBuildConfig(
       env as ForgedConfigEnv<"build">,
       config,
       "main",
-      target ?? "es",
+      "es",
     );
 }
 
 export function extendPreloadConfig(
   config: UserConfigExport,
-  target?: "cjs" | "es",
 ): UserConfigExport {
   return async (env: ConfigEnv) =>
     await applyBaseBuildConfig(
       env as ForgedConfigEnv<"build">,
       config,
       "preload",
-      target ?? "cjs",
+      "cjs",
     );
 }
 
@@ -107,16 +103,7 @@ async function applyBaseBuildConfig(
   const { root, mode, command } = env;
   const { entry } = env.forgeConfigSelf;
   const format = target;
-  const esExt = pkg.type === "module" ? "js" : "mjs";
-  const cjsExt = pkg.type === "module" ? "cjs" : "js";
-  const targetExt =
-    target === "cjs"
-      ? type === "preload"
-        ? "cjs"
-        : cjsExt
-      : type === "preload"
-        ? "mjs"
-        : esExt;
+  const targetExt = target === "cjs" ? "cjs" : "js";
 
   const define = env.forgeConfig.renderer
     .map(({ name }) => name)
@@ -162,6 +149,7 @@ async function applyBaseBuildConfig(
         }),
         rollupOptions: {
           external,
+          treeshake: false,
           ...(type === "preload" && {
             input: entry,
             output: {