Skip to content

Commit 76f539b

Browse files
authored
chore: GridListSection docs testing followup (#9475)
* chore: GridListSection docs testing follow-up * fix listbox sections
1 parent 257345c commit 76f539b

File tree

4 files changed

+36
-4
lines changed

4 files changed

+36
-4
lines changed

packages/dev/s2-docs/pages/react-aria/GridList.mdx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -564,8 +564,8 @@ import {GridListHeader, GridListSection, Text} from 'react-aria-components';
564564
</GridListItem>
565565
</GridListSection>
566566
<GridListSection>
567-
<GridListHeader>Vegetables</GridListHeader>
568-
<GridListItem textValue="Broccoli">
567+
<GridListHeader>Vegetables</GridListHeader>
568+
<GridListItem textValue="Broccoli">
569569
<img src="https://images.unsplash.com/photo-1685504445355-0e7bdf90d415?q=80&w=928&auto=format&fit=crop&ixlib=rb-4.1.0&ixid=M3wxMjA3fDB8MHxwaG90by1wYWdlfHx8fGVufDB8fHx8fA%3D%3D" width={600} height={900} />
570570
<Text>Broccoli</Text>
571571
<Text slot="description">PNG • 5/30/2023</Text>

starters/docs/src/GridList.css

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,10 @@
1616
box-sizing: border-box;
1717
--grid-item-size: 200px;
1818

19+
&:has(.react-aria-GridListSection) {
20+
scroll-padding: 50px;
21+
}
22+
1923
&[data-layout=grid]:not(:has(.react-aria-GridListSection)) {
2024
display: grid;
2125
grid-template-columns: repeat(auto-fit, minmax(100px, var(--grid-item-size)));
@@ -266,7 +270,7 @@
266270
font-size: var(--font-size-lg);
267271
font-weight: 500;
268272
background: var(--gray-100);
269-
border-block: 0.5px solid var(--gray-400);
273+
border: 0.5px solid var(--gray-400);
270274
cursor: default;
271275
user-select: none;
272276
box-shadow: inset 0px 1px 0px white, inset 0px -4px 8px var(--gray-200);

starters/docs/src/ListBox.css

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,10 @@
1212
font: var(--font-size) system-ui;
1313
color: var(--text-color);
1414

15+
&:has(.react-aria-ListBoxSection){
16+
scroll-padding: 24px;
17+
}
18+
1519
&[data-focus-visible] {
1620
outline: 2px solid var(--focus-ring-color);
1721
outline-offset: -1px;

starters/docs/stories/ListBox.stories.tsx

Lines changed: 25 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
import {ListBox, ListBoxItem} from '../src/ListBox';
1+
import {ListBox, ListBoxItem, ListBoxSection} from '../src/ListBox';
2+
import {Header} from 'react-aria-components';
23

34
import type {Meta, StoryFn} from '@storybook/react';
45

@@ -26,3 +27,26 @@ Example.args = {
2627
onAction: undefined,
2728
selectionMode: 'single'
2829
};
30+
31+
export const Sections: Story = (args) => (
32+
<ListBox aria-label="Sandwich contents" selectionMode="multiple">
33+
<ListBoxSection>
34+
<Header>Veggies</Header>
35+
<ListBoxItem id="lettuce">Lettuce</ListBoxItem>
36+
<ListBoxItem id="tomato">Tomato</ListBoxItem>
37+
<ListBoxItem id="onion">Onion</ListBoxItem>
38+
</ListBoxSection>
39+
<ListBoxSection>
40+
<Header>Protein</Header>
41+
<ListBoxItem id="ham">Ham</ListBoxItem>
42+
<ListBoxItem id="tuna">Tuna</ListBoxItem>
43+
<ListBoxItem id="tofu">Tofu</ListBoxItem>
44+
</ListBoxSection>
45+
<ListBoxSection>
46+
<Header>Condiments</Header>
47+
<ListBoxItem id="mayo">Mayonaise</ListBoxItem>
48+
<ListBoxItem id="mustard">Mustard</ListBoxItem>
49+
<ListBoxItem id="ranch">Ranch</ListBoxItem>
50+
</ListBoxSection>
51+
</ListBox>
52+
)

0 commit comments

Comments
 (0)