improve test instruction extraction

Author: yihuiliao

scripts/getCommitsForTesting.mjs

@@ -8,7 +8,7 @@ import {unified} from 'unified';
 /**
  * Instructions:
  * 
- * 1. Run the following script: node scripts/getCommitsForTesting.js 2025-10-07 2025-10-18
+ * 1. Run the following script: node scripts/getCommitsForTesting.mjs 2025-10-07 2025-10-18
  * 2. Go to output.csv, copy it to Google sheets, highlight the rows, go to "Data" in the toolbar -> split text to columns -> separator: comma
  */
 
@@ -53,7 +53,7 @@ async function writeTestingCSV() {
       let content = info.data.body;
       let testInstructions = escapeCSV(extractTestInstructions(content));
 
-      if (testInstructions.length > 350) {
+      if (testInstructions.length > 300) {
         row.push('See PR for testing instructions');
       } else {
         row.push(testInstructions);
@@ -62,16 +62,21 @@ async function writeTestingCSV() {
       // Add PR url to the row
       row.push(info.data.html_url);
 
-      // Categorize commit into V3, RAC, S2, or other
-      // I feel like maybe we should use labels rather than looking at the PR title for this but we would need to get into the habit of doing that
-      if ((/\bs2\b/gi).test(title)) {
-        s2PRs.push(row);
-      } else if ((/\brac\b/gi).test(title)) {
-        racPRs.push(row);
-      } else if ((/\bv3\b/gi).test(title)) {
-        v3PRs.push(row);
-      } else {
+      // Categorize commit into V3, RAC, S2, or other (utilizes labels on PR's to categorize)
+      let labels = info.data.labels;
+      if (labels.length === 0) {
         otherPRs.push(row);
+      } else {
+        for (let label of labels) {
+          // eslint-disable-next-line max-depth
+          if (label.name === 'S2') {
+            s2PRs.push(row);
+          } else if (label.name === 'RAC') {
+            racPRs.push(row);
+          } else if (label.name === 'V3') {
+            v3PRs.push(row);
+          }
+        }
       }
     }
   }
@@ -83,17 +88,17 @@ async function writeTestingCSV() {
     csvRows += v3.join() + '\n';
   }
 
-  csvRows += '\nRainbow \n'
+  csvRows += '\nRainbow \n';
   for (let s2 of s2PRs) {
     csvRows += s2.join() + '\n';
   }
 
-  csvRows += '\nRAC \n'
+  csvRows += '\nRAC \n';
   for (let rac of racPRs) {
     csvRows += rac.join() + '\n';
   }
 
-  csvRows += '\nOther \n'
+  csvRows += '\nOther \n';
   for (let other of otherPRs) {
     csvRows += other.join() + '\n';
   }
@@ -112,8 +117,8 @@ async function listCommits() {
   let end = new Date(args.positionals[1]);
 
   if (isNaN(start.getTime()) || isNaN(end.getTime())) {
-    console.error('Please verify that your date is correctly formatted')
-    process.exit(1)
+    console.error('Please verify that your date is correctly formatted');
+    process.exit(1);
   }
 
   let startDate = new Date(start).toISOString();
@@ -146,7 +151,7 @@ function getHeadingText(node) {
   return node.children
     .map(child => child.value || '')
     .join('')
-    .trim()
+    .trim();
 }
 
 function extractTestInstructions(contents) {
@@ -182,7 +187,7 @@ function extractTestInstructions(contents) {
 
   }
 
-  return collected.map(node => toString(node)).join('\n').trim();
+  return collected.map(node => toString(node)).join(' ').replace(/\r\n/g, '\n').replace(/\s+/g, ' ').trim();
 }
 
 
@@ -200,17 +205,3 @@ function escapeCSV(value) {
   // Wrap in quotes so commas/newlines don't break the cell
   return `"${escaped}"`;
 }
-
-// We can bring this back if we start using the "needs testing" label
-// function isReadyForTesting(labels){
-//   if (labels.length === 0) {
-//     return false;
-//   }
-//   for (let label of labels) {
-//     if (label.name === 'needs testing') {
-//       return true;
-//     }
-//   }
-
-//   return false;
-// }